Bug 105995 - Add FloatPoint::distance(Squared)ToPoint(const FloatPoint&) to match IntPoint
Summary: Add FloatPoint::distance(Squared)ToPoint(const FloatPoint&) to match IntPoint
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Steve Block
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-02 21:43 PST by Steve Block
Modified: 2023-09-19 14:02 PDT (History)
9 users (show)

See Also:

Attachments
Patch (9.37 KB, patch)
2013-01-02 21:45 PST, Steve Block 		darin: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2013-01-02 21:43:42 PST 
Add FloatPoint::distance(Squared)ToPoint(const FloatPoint&) to match IntPoint
Comment 1 Steve Block 2013-01-02 21:45:00 PST 
Created attachment 181146 [details]
Patch
Comment 2 Steve Block 2013-01-02 22:18:18 PST 
Calculating the distance between two FloatPoints is a common operation, and IntPoint already has such a method, so it seems like a good idea to add these helpers to FloatPoint.
Comment 3 Darin Adler 2013-04-08 18:12:26 PDT 
Comment on attachment 181146 [details]
Patch

OK
Comment 4 WebKit Commit Bot 2013-04-08 18:14:52 PDT 
Comment on attachment 181146 [details]
Patch

Rejecting attachment 181146 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 181146, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
m/graphics/FloatPoint.h
Hunk #1 FAILED at 149.
Hunk #2 succeeded at 275 (offset 5 lines).
1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/platform/graphics/FloatPoint.h.rej
patching file Source/WebCore/platform/graphics/gpu/LoopBlinnLocalTriangulator.cpp
patching file Source/WebCore/platform/graphics/gpu/LoopBlinnMathUtils.cpp

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Darin Adler']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-commit-queue.appspot.com/results/17671010
Comment 5 Ahmad Saleem 2023-09-19 14:02:17 PDT 
Do we need this now?