Bug 106105 - Can't compile MathExtras.h using MinGW-w64
Summary: Can't compile MathExtras.h using MinGW-w64
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 106099
  Show dependency tree / graph
 
Reported: 2013-01-04 10:09 PST by Jonathan Liu
Modified: 2013-01-05 12:04 PST (History)
6 users (show)

See Also:

Attachments
Patch (2.68 KB, patch)
2013-01-04 10:17 PST, Jonathan Liu 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Liu 2013-01-04 10:09:58 PST 
r138705 caused MathExtras.h to fail to compile as wtf_pow need isfinite and isinf. isfinite and isinf is defined after wtf_pow with "using std::isfinite" and "using std::isinf".
Comment 1 Jonathan Liu 2013-01-04 10:17:12 PST 
Created attachment 181323 [details]
Patch
Comment 2 WebKit Review Bot 2013-01-04 10:20:34 PST 
Attachment 181323 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Ma..." exit_code: 1
Source/WTF/wtf/MathExtras.h:351:  wtf_pow is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Review Bot 2013-01-04 11:53:17 PST 
Comment on attachment 181323 [details]
Patch

Attachment 181323 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15699223

New failing tests:
inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html
Comment 4 WebKit Review Bot 2013-01-05 12:04:08 PST 
Comment on attachment 181323 [details]
Patch

Clearing flags on attachment: 181323

Committed r138894: <http://trac.webkit.org/changeset/138894>
Comment 5 WebKit Review Bot 2013-01-05 12:04:12 PST 
All reviewed patches have been landed.  Closing bug.