WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
106099
Only enable MinGW-w64 pow() workaround if needed
https://bugs.webkit.org/show_bug.cgi?id=106099
Summary
Only enable MinGW-w64 pow() workaround if needed
Jonathan Liu
Reported
2013-01-04 09:11:09 PST
The pow() workaround in Source/WTF/wtf/MathExtras.h for MinGW-w64 is no longer required in the latest version of MinGW-w64. Only enable the workaround if it is required.
Attachments
Patch
(1.49 KB, patch)
2013-01-04 09:15 PST
,
Jonathan Liu
no flags
Details
Formatted Diff
Diff
Patch
(1.56 KB, patch)
2013-01-04 16:58 PST
,
Jonathan Liu
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Jonathan Liu
Comment 1
2013-01-04 09:15:19 PST
Created
attachment 181312
[details]
Patch
Jonathan Liu
Comment 2
2013-01-04 16:58:54 PST
Created
attachment 181412
[details]
Patch
Jonathan Liu
Comment 3
2013-01-04 17:11:54 PST
There is a warning generated if __MINGW64_VERSION_RC is not defined and compiling with -Wundef so I added another check if it is defined.
WebKit Review Bot
Comment 4
2013-01-04 18:50:25 PST
Comment on
attachment 181412
[details]
Patch
Attachment 181412
[details]
did not pass chromium-ews (chromium-xvfb): Output:
http://queues.webkit.org/results/15708445
New failing tests: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html
WebKit Review Bot
Comment 5
2013-01-05 12:51:32 PST
Comment on
attachment 181412
[details]
Patch Clearing flags on attachment: 181412 Committed
r138903
: <
http://trac.webkit.org/changeset/138903
>
WebKit Review Bot
Comment 6
2013-01-05 12:51:36 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug