Bug 106099 - Only enable MinGW-w64 pow() workaround if needed
Summary: Only enable MinGW-w64 pow() workaround if needed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 106105
Blocks:
  Show dependency treegraph
 
Reported: 2013-01-04 09:11 PST by Jonathan Liu
Modified: 2013-01-05 12:51 PST (History)
7 users (show)

See Also:


Attachments
Patch (1.49 KB, patch)
2013-01-04 09:15 PST, Jonathan Liu
no flags Details | Formatted Diff | Diff
Patch (1.56 KB, patch)
2013-01-04 16:58 PST, Jonathan Liu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Liu 2013-01-04 09:11:09 PST
The pow() workaround in Source/WTF/wtf/MathExtras.h for MinGW-w64 is no longer required in the latest version of MinGW-w64. Only enable the workaround if it is required.
Comment 1 Jonathan Liu 2013-01-04 09:15:19 PST
Created attachment 181312 [details]
Patch
Comment 2 Jonathan Liu 2013-01-04 16:58:54 PST
Created attachment 181412 [details]
Patch
Comment 3 Jonathan Liu 2013-01-04 17:11:54 PST
There is a warning generated if __MINGW64_VERSION_RC is not defined and compiling with -Wundef so I added another check if it is defined.
Comment 4 WebKit Review Bot 2013-01-04 18:50:25 PST
Comment on attachment 181412 [details]
Patch

Attachment 181412 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15708445

New failing tests:
inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html
Comment 5 WebKit Review Bot 2013-01-05 12:51:32 PST
Comment on attachment 181412 [details]
Patch

Clearing flags on attachment: 181412

Committed r138903: <http://trac.webkit.org/changeset/138903>
Comment 6 WebKit Review Bot 2013-01-05 12:51:36 PST
All reviewed patches have been landed.  Closing bug.