REGRESSION(r138544): [GTK] Clicking on selected text in a text editable deletes the selection

[Carlos Garcia Campos]

The problem is that GtkInputMethodFilter::notifyMouseButtonPress() in WebKit2 always confirms a text composition, instead of the current composition.

[Carlos Garcia Campos]

Created attachment 181286 [details]
Patch

[WebKit Review Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Martin Robinson]

I think the patch I posted yesterday might be more complete.

*** This bug has been marked as a duplicate of bug 106045 ***

[Martin Robinson]

Comment on attachment 181286 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=181286&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:626
> -    priv->inputMethodFilter.notifyMouseButtonPress();
> -
>      if (!priv->clickCounter.shouldProcessButtonEvent(buttonEvent))
>          return TRUE;
>  
>      // If it's a right click event save it as a possible context menu event.
>      if (buttonEvent->button == 3)
>          priv->contextMenuEvent.set(gdk_event_copy(reinterpret_cast<GdkEvent*>(buttonEvent)));
> +
> +    priv->inputMethodFilter.notifyMouseButtonPress();

I think either way, it makes sense to cancel the composition. clickCounter.shouldProcessButtonEvent just discards "extra" events that happen during the process of multi-clicking, so the chances of this making a difference are pretty small.

[Eric Seidel (no email)]

Comment on attachment 181286 [details]
Patch

Cleared review? from attachment 181286 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).