Bug 106045 - [GTK] [WebKit2] Clicking on a word that is selected in an editable area deletes it
Summary: [GTK] [WebKit2] Clicking on a word that is selected in an editable area delet...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords:
: 106081 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-01-03 14:53 PST by Martin Robinson
Modified: 2014-03-30 03:03 PDT (History)
6 users (show)

See Also:

Attachments
Patch (4.66 KB, patch)
2013-01-03 15:18 PST, Martin Robinson 		no flags Details | Formatted Diff | Diff
Another patch (2.75 KB, patch)
2013-01-04 09:25 PST, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2013-01-03 14:53:10 PST 
Selecting a word in an editable region and then clicking causes the word to be deleted.
Comment 1 Martin Robinson 2013-01-03 15:18:40 PST 
Created attachment 181231 [details]
Patch
Comment 2 Martin Robinson 2013-01-04 08:34:17 PST 
*** Bug 106081 has been marked as a duplicate of this bug. ***
Comment 3 Carlos Garcia Campos 2013-01-04 09:25:09 PST 
Created attachment 181315 [details]
Another patch

I think both patches can be complementary. this patch ensures we do the same than we currently in wk1. 

GtkInputMethodFilter::notifyMouseButtonPress() calls confirmCurrentComposition() which ends up calling Editor::confirmComposition(), the version without receiving a String. In WebKit2, we are using a single message ConfirmComposition. When confirmCurrentComposition is called in WebKit2 ConfirmComposition message is sent with a NULL String, and the web process ends up calling Editor::confirmComposition(String). We need to handle the special case of the NULL string to call Editor::confirmComposition() without the string.
Comment 4 Carlos Garcia Campos 2013-01-04 09:26:10 PST 
Adding Simon and Kenneth to the CC because Qt might be affected by this too.
Comment 5 WebKit Review Bot 2013-01-04 09:29:56 PST 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 6 Carlos Garcia Campos 2013-01-04 09:38:49 PST 
Comment on attachment 181231 [details]
Patch

This looks sane to me, and we save an IPC message when we are not composing. Thanks!
Comment 7 WebKit Review Bot 2013-01-04 09:42:59 PST 
Comment on attachment 181231 [details]
Patch

Clearing flags on attachment: 181231

Committed r138806: <http://trac.webkit.org/changeset/138806>
Comment 8 Sergio Villar Senin 2013-02-08 07:51:56 PST 
Should we close this?
Comment 9 Martin Robinson 2013-02-08 07:54:02 PST 
The GTK+ parts of this look good to me, but a WebKit2 OWNER needs to look at the other change.
Comment 10 Martin Robinson 2014-03-29 15:15:26 PDT 
Are we going to move this one forward?
Comment 11 Carlos Garcia Campos 2014-03-30 03:03:40 PDT 
Comment on attachment 181315 [details]
Another patch

No, this is working fine now