Bug 106076 - Rename Tool.port to deprecated_port in preparation for removing more callers
Summary: Rename Tool.port to deprecated_port in preparation for removing more callers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-03 19:25 PST by Eric Seidel (no email)
Modified: 2013-01-03 19:57 PST (History)
3 users (show)

See Also:


Attachments
Patch (17.42 KB, patch)
2013-01-03 19:26 PST, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff
Patch for landing (18.64 KB, patch)
2013-01-03 19:44 PST, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2013-01-03 19:25:59 PST
Rename Tool.port to deprecated_port in preparation for removing more callers
Comment 1 Eric Seidel (no email) 2013-01-03 19:26:30 PST
Created attachment 181263 [details]
Patch
Comment 2 Eric Seidel (no email) 2013-01-03 19:26:59 PST
test-webkitpy                                                                                                 [~/Projects/WebKit]
Suppressing most webkitpy logging while running unit tests.
Skipping tests in the following modules or packages because they are really, really, slow:
    webkitpy.common.checkout.scm.scm_unittest
    (https://bugs.webkit.org/show_bug.cgi?id=31818; use --all to include)

[[Ran 1614 tests in 4.783s                                                                                                              

OK
Comment 3 Ryosuke Niwa 2013-01-03 19:27:44 PST
Comment on attachment 181263 [details]
Patch

rs=me.
Comment 4 WebKit Review Bot 2013-01-03 19:29:38 PST
Attachment 181263 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1
Tools/Scripts/webkitpy/tool/mocktool.py:74:  [MockTool.deprecated_port] An attribute affected in webkitpy.tool.steps.steps_unittest line 105 hide this method  [pylint/E0202] [5]
Total errors found: 1 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Eric Seidel (no email) 2013-01-03 19:35:39 PST
Comment on attachment 181263 [details]
Patch

The style error concerns me.  Investigating.
Comment 6 Eric Seidel (no email) 2013-01-03 19:44:00 PST
Created attachment 181268 [details]
Patch for landing
Comment 7 WebKit Review Bot 2013-01-03 19:57:50 PST
Comment on attachment 181268 [details]
Patch for landing

Clearing flags on attachment: 181268

Committed r138775: <http://trac.webkit.org/changeset/138775>
Comment 8 WebKit Review Bot 2013-01-03 19:57:54 PST
All reviewed patches have been landed.  Closing bug.