Bug 106076 – Rename Tool.port to deprecated_port in preparation for removing more callers

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Eric Seidel (no email)]

Rename Tool.port to deprecated_port in preparation for removing more callers

[Eric Seidel (no email)]

Created attachment 181263 [details]
Patch

[Eric Seidel (no email)]

test-webkitpy                                                                                                 [~/Projects/WebKit]
Suppressing most webkitpy logging while running unit tests.
Skipping tests in the following modules or packages because they are really, really, slow:
    webkitpy.common.checkout.scm.scm_unittest
    (https://bugs.webkit.org/show_bug.cgi?id=31818; use --all to include)

[[Ran 1614 tests in 4.783s                                                                                                              

OK

[Ryosuke Niwa]

Comment on attachment 181263 [details]
Patch

rs=me.

[WebKit Review Bot]

Attachment 181263 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1
Tools/Scripts/webkitpy/tool/mocktool.py:74:  [MockTool.deprecated_port] An attribute affected in webkitpy.tool.steps.steps_unittest line 105 hide this method  [pylint/E0202] [5]
Total errors found: 1 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Eric Seidel (no email)]

Comment on attachment 181263 [details]
Patch

The style error concerns me.  Investigating.

[Eric Seidel (no email)]

Created attachment 181268 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 181268 [details]
Patch for landing

Clearing flags on attachment: 181268

Committed r138775: <http://trac.webkit.org/changeset/138775>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.