Bug 106064 – REGRESSION(r111439): Focus ring is rendered incorrectly in fast/inline/continuation-outlines-with-layers.html

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Ryosuke Niwa]

Created attachment 181248 [details]
Actual Image

See the attached image. Outline ring is painted incorrectly.

[Ryosuke Niwa]

Updated test expectations in http://trac.webkit.org/changeset/138761.

[Radar WebKit Bug Importer]

<rdar://problem/12954200>

[Simon Fraser (smfr)]

When did this regress?

[Ryosuke Niwa]

(In reply to comment #3)
> When did this regress?

No idea. The test had been skipped until I removed it from TestExpectations file in http://trac.webkit.org/changeset/138734 since the bug associated with it had been resolved :(

[Ryosuke Niwa]

It appears to be a regression from http://trac.webkit.org/changeset/111439.

[Ryosuke Niwa]

From the change log of r111439:

​https://trac.webkit.org/changeset/108185/ allowed anonymous blocks to get their own layer (when they're
relatively positioned). This broke the dependency in addContinuationWithOutline() on the owner of the continuation
table and the renderer getting added to it always being in the same layer. When they're not in the same layer
there's no guarantee that the owner of the continuation table will get painted again and so avoid any stale pointers
in its continuation table should any of the renderers in there get destroyed.
Fix this for now by only adding renderers to the containing block's continuation table if we don't have our own layer.
This fix causes fast/inline/continuation-outlines-with-layers.html to regress as it uses blocks inside relatively positioned
inlines, so skip it on all platforms pending a medium-term fix.

[Robert Hogan]

*** Bug 81819 has been marked as a duplicate of this bug. ***

[Robert Hogan]

Created attachment 181565 [details]
Patch

[Build Bot]

Comment on attachment 181565 [details]
Patch

Attachment 181565 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15739912

New failing tests:
fast/inline/continuation-outlines-with-layers.html

[Robert Hogan]

(In reply to comment #9)
> (From update of attachment 181565 [details])
> Attachment 181565 [details] did not pass mac-ews (mac):
> Output: http://queues.webkit.org/results/15739912
> 
> New failing tests:
> fast/inline/continuation-outlines-with-layers.html

This is a text-only failure and the change in behaviour will only show up on the pixel results. Mac's RenderTree results for this are out of date, and have missed updates for sub-pixel rebaselines at the very least.

[Dave Hyatt]

Comment on attachment 181565 [details]
Patch

Test results don't look right? Shouldn't the before merge in rather than painting separately?

[Robert Hogan]

(In reply to comment #11)
> (From update of attachment 181565 [details])
> Test results don't look right? Shouldn't the before merge in rather than painting separately?

It has always rendered this way in Chromium as far as I can tell, e.g.:

http://trac.webkit.org/browser/trunk/LayoutTests/platform/chromium-linux/fast/inline/continuation-outlines-with-layers-expected.png?rev=84406

[Dave Hyatt]

Comment on attachment 181565 [details]
Patch

r=me, but make sure we get a bug filed on the fact that the Chromium Linux results are wrong-looking.

[WebKit Review Bot]

Comment on attachment 181565 [details]
Patch

Clearing flags on attachment: 181565

Committed r139223: <http://trac.webkit.org/changeset/139223>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.