Bug 106000 - Default build of WebKit nightly (revision 138697) broken for Gtk port, VIDEO_TRACK disabling problem
Summary: Default build of WebKit nightly (revision 138697) broken for Gtk port, VIDEO_...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-02 23:11 PST by jaybhaskar
Modified: 2013-01-07 12:06 PST (History)
2 users (show)

See Also:

Attachments
This patch is for Webcore GNUMakefile.am, which enables VIDEO_TRACK macro (1.29 KB, patch)
2013-01-03 05:05 PST, jaybhaskar 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jaybhaskar 2013-01-02 23:11:33 PST 
Simply ./autogen.sh
and then make command gives below error

DerivedSources/webkitdom/WebKitDOMTextTrack.cpp: In function ‘void webkit_dom_text_track_dispatch_event(WebKitDOMEventTarget*, WebKitDOMEvent*, GError**)’:
DerivedSources/webkitdom/WebKitDOMTextTrack.cpp:82:15: error: invalid use of incomplete type ‘class WebCore::TextTrack’
In file included from ./Source/WebCore/bindings/gobject/GObjectEventListener.h:23:0,
                 from DerivedSources/webkitdom/WebKitDOMTextTrack.cpp:26:
./Source/WebCore/dom/EventTarget.h:69:11: error: forward declaration of ‘class WebCore::TextTrack’
DerivedSources/webkitdom/WebKitDOMTextTrack.cpp: In function ‘gboolean webkit_dom_text_track_add_event_listener(WebKitDOMEventTarget*, const char*, GCallback, gboolean, gpointer)’:
DerivedSources/webkitdom/WebKitDOMTextTrack.cpp:92:126: error: no matching function for call to ‘WebCore::GObjectEventListener::addEventListener(GObject*, WebCore::TextTrack*&, const char*&, void (*&)(), gboolean&, void*&)’
DerivedSources/webkitdom/WebKitDOMTextTrack.cpp:92:126: note: candidate is:
In file included from DerivedSources/webkitdom/WebKitDOMTextTrack.cpp:26:0:
./Source/WebCore/bindings/gobject/GObjectEventListener.h:35:17: note: static bool WebCore::GObjectEventListener::addEventListener(GObject*, WebCore::EventTarget*, const char*, GCallback, bool, void*)
./Source/WebCore/bindings/gobject/GObjectEventListener.h:35:17: note:   no known conversion for argument 2 from ‘WebCore::TextTrack*’ to ‘WebCore::EventTarget*’
DerivedSources/webkitdom/WebKitDOMTextTrack.cpp: In function ‘gboolean webkit_dom_text_track_remove_event_listener(WebKitDOMEventTarget*, const char*, GCallback, gboolean)’:
DerivedSources/webkitdom/WebKitDOMTextTrack.cpp:98:119: error: no matching function for call to ‘WebCore::GObjectEventListener::removeEventListener(GObject*, WebCore::TextTrack*&, const char*&, void (*&)(), gboolean&)’
DerivedSources/webkitdom/WebKitDOMTextTrack.cpp:98:119: note: candidate is:
In file included from DerivedSources/webkitdom/WebKitDOMTextTrack.cpp:26:0:
./Source/WebCore/bindings/gobject/GObjectEventListener.h:41:17: note: static bool WebCore::GObjectEventListener::removeEventListener(GObject*, WebCore::EventTarget*, const char*, GCallback, bool)
./Source/WebCore/bindings/gobject/GObjectEventListener.h:41:17: note:   no known conversion for argument 2 from ‘WebCore::TextTrack*’ to ‘WebCore::EventTarget*’
DerivedSources/webkitdom/WebKitDOMTextTrack.cpp:99:1: warning: control reaches end of non-void function [-Wreturn-type]
DerivedSources/webkitdom/WebKitDOMTextTrack.cpp: In function ‘gboolean webkit_dom_text_track_add_event_listener(WebKitDOMEventTarget*, const char*, GCallback, gboolean, gpointer)’:
DerivedSources/webkitdom/WebKitDOMTextTrack.cpp:93:1: warning: control reaches end of non-void function [-Wreturn-type]
make[1]: *** [DerivedSources/webkitdom/libWebCoreDOM_la-WebKitDOMTextTrack.lo] Error 1
make[1]: Leaving directory `/opt/WebKit'
make: *** [all] Error 2




I have analyzed it and found that VIDEO_TRACK macro becomes disable by default.
Comment 1 jaybhaskar 2013-01-03 05:05:32 PST 
Created attachment 181164 [details]
This patch is for Webcore GNUMakefile.am, which enables VIDEO_TRACK macro 

This resolves build issue for Video track module
Comment 2 Philippe Normand 2013-01-07 08:27:00 PST 
Žan wdyt? I'm rather perplex about this patch.
Comment 3 Zan Dobersek 2013-01-07 11:57:22 PST 
This failure is already fixed in tip of tree, it was fixed by bug #105743.
http://trac.webkit.org/changeset/138793

Compilation with VIDEO_TRACK feature either enabled or disabled should now pass.
Comment 4 Zan Dobersek 2013-01-07 12:05:42 PST 
Closing as fixed for now, but if you still see these failures with an up-to-date nightly feel free to report them.
Comment 5 Zan Dobersek 2013-01-07 12:06:07 PST 
Comment on attachment 181164 [details]
This patch is for Webcore GNUMakefile.am, which enables VIDEO_TRACK macro 

Clearing review/cq flags.