Bug 106000 – Default build of WebKit nightly (revision 138697) broken for Gtk port, VIDEO_TRACK disabling problem

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[jaybhaskar]

Simply ./autogen.sh
and then make command gives below error

DerivedSources/webkitdom/WebKitDOMTextTrack.cpp: In function ‘void webkit_dom_text_track_dispatch_event(WebKitDOMEventTarget*, WebKitDOMEvent*, GError**)’:
DerivedSources/webkitdom/WebKitDOMTextTrack.cpp:82:15: error: invalid use of incomplete type ‘class WebCore::TextTrack’
In file included from ./Source/WebCore/bindings/gobject/GObjectEventListener.h:23:0,
                 from DerivedSources/webkitdom/WebKitDOMTextTrack.cpp:26:
./Source/WebCore/dom/EventTarget.h:69:11: error: forward declaration of ‘class WebCore::TextTrack’
DerivedSources/webkitdom/WebKitDOMTextTrack.cpp: In function ‘gboolean webkit_dom_text_track_add_event_listener(WebKitDOMEventTarget*, const char*, GCallback, gboolean, gpointer)’:
DerivedSources/webkitdom/WebKitDOMTextTrack.cpp:92:126: error: no matching function for call to ‘WebCore::GObjectEventListener::addEventListener(GObject*, WebCore::TextTrack*&, const char*&, void (*&)(), gboolean&, void*&)’
DerivedSources/webkitdom/WebKitDOMTextTrack.cpp:92:126: note: candidate is:
In file included from DerivedSources/webkitdom/WebKitDOMTextTrack.cpp:26:0:
./Source/WebCore/bindings/gobject/GObjectEventListener.h:35:17: note: static bool WebCore::GObjectEventListener::addEventListener(GObject*, WebCore::EventTarget*, const char*, GCallback, bool, void*)
./Source/WebCore/bindings/gobject/GObjectEventListener.h:35:17: note:   no known conversion for argument 2 from ‘WebCore::TextTrack*’ to ‘WebCore::EventTarget*’
DerivedSources/webkitdom/WebKitDOMTextTrack.cpp: In function ‘gboolean webkit_dom_text_track_remove_event_listener(WebKitDOMEventTarget*, const char*, GCallback, gboolean)’:
DerivedSources/webkitdom/WebKitDOMTextTrack.cpp:98:119: error: no matching function for call to ‘WebCore::GObjectEventListener::removeEventListener(GObject*, WebCore::TextTrack*&, const char*&, void (*&)(), gboolean&)’
DerivedSources/webkitdom/WebKitDOMTextTrack.cpp:98:119: note: candidate is:
In file included from DerivedSources/webkitdom/WebKitDOMTextTrack.cpp:26:0:
./Source/WebCore/bindings/gobject/GObjectEventListener.h:41:17: note: static bool WebCore::GObjectEventListener::removeEventListener(GObject*, WebCore::EventTarget*, const char*, GCallback, bool)
./Source/WebCore/bindings/gobject/GObjectEventListener.h:41:17: note:   no known conversion for argument 2 from ‘WebCore::TextTrack*’ to ‘WebCore::EventTarget*’
DerivedSources/webkitdom/WebKitDOMTextTrack.cpp:99:1: warning: control reaches end of non-void function [-Wreturn-type]
DerivedSources/webkitdom/WebKitDOMTextTrack.cpp: In function ‘gboolean webkit_dom_text_track_add_event_listener(WebKitDOMEventTarget*, const char*, GCallback, gboolean, gpointer)’:
DerivedSources/webkitdom/WebKitDOMTextTrack.cpp:93:1: warning: control reaches end of non-void function [-Wreturn-type]
make[1]: *** [DerivedSources/webkitdom/libWebCoreDOM_la-WebKitDOMTextTrack.lo] Error 1
make[1]: Leaving directory `/opt/WebKit'
make: *** [all] Error 2




I have analyzed it and found that VIDEO_TRACK macro becomes disable by default.

[jaybhaskar]

Created attachment 181164 [details]
This patch is for Webcore GNUMakefile.am, which enables VIDEO_TRACK macro 

This resolves build issue for Video track module

[Philippe Normand]

Žan wdyt? I'm rather perplex about this patch.

[Zan Dobersek]

This failure is already fixed in tip of tree, it was fixed by bug #105743.
http://trac.webkit.org/changeset/138793

Compilation with VIDEO_TRACK feature either enabled or disabled should now pass.

[Zan Dobersek]

Closing as fixed for now, but if you still see these failures with an up-to-date nightly feel free to report them.

[Zan Dobersek]

Comment on attachment 181164 [details]
This patch is for Webcore GNUMakefile.am, which enables VIDEO_TRACK macro 

Clearing review/cq flags.