Bug 105743 - [GObject bindings] Wrap event target interface code in feature define guards if necessary
Summary: [GObject bindings] Wrap event target interface code in feature define guards ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords: Gtk
: 95937 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-12-25 10:25 PST by Zan Dobersek
Modified: 2013-05-07 01:45 PDT (History)
6 users (show)

See Also:

Attachments
Patch (7.23 KB, patch)
2012-12-25 10:35 PST, Zan Dobersek 		xan.lopez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2012-12-25 10:25:05 PST 
Like other binding method implementations, the event target interface code should be guarded by the feature define guards if present.

This problem currently shows when building WebKitGTK+ with video track feature disabled.
Comment 1 Zan Dobersek 2012-12-25 10:35:47 PST 
Created attachment 180714 [details]
Patch
Comment 2 Xan Lopez 2013-01-04 02:02:47 PST 
Looks sane. No need to update the bindings tests after this?
Comment 3 Zan Dobersek 2013-01-04 02:53:28 PST 
(In reply to comment #2)
> Looks sane. No need to update the bindings tests after this?

No, no tests are affected. I guess no event target behind a conditional is present in the bindings tests.
Comment 4 Xan Lopez 2013-01-04 04:07:55 PST 
Comment on attachment 180714 [details]
Patch

OK, let's do it.
Comment 5 Zan Dobersek 2013-01-04 06:14:38 PST 
Committed r138793: <http://trac.webkit.org/changeset/138793>
Comment 6 Zan Dobersek 2013-05-07 01:45:52 PDT 
*** Bug 95937 has been marked as a duplicate of this bug. ***