Bug 105864 - Rename StyleResolver's member variable that holds SelectorChecker to a proper name.
Summary: Rename StyleResolver's member variable that holds SelectorChecker to a proper...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on:
Blocks: 89879
  Show dependency tree / graph
 
Reported: 2012-12-29 16:44 PST by Dimitri Glazkov (Google)
Modified: 2013-01-08 21:06 PST (History)
8 users (show)

See Also:

Attachments
Patch (8.63 KB, patch)
2012-12-29 16:46 PST, Dimitri Glazkov (Google) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2012-12-29 16:44:35 PST 
Rename StyleResolver's member variable that holds SelectorChecker to a proper name.
Comment 1 Dimitri Glazkov (Google) 2012-12-29 16:46:45 PST 
Created attachment 180947 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-12-29 16:49:27 PST 
Comment on attachment 180947 [details]
Patch

LGTM.
Comment 3 WebKit Review Bot 2012-12-29 17:24:03 PST 
Comment on attachment 180947 [details]
Patch

Clearing flags on attachment: 180947

Committed r138572: <http://trac.webkit.org/changeset/138572>
Comment 4 WebKit Review Bot 2012-12-29 17:24:07 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Antti Koivisto 2012-12-30 00:35:52 PST 
Comment on attachment 180947 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180947&action=review

> Source/WebCore/css/StyleResolver.cpp:2260
> -    SelectorChecker::SelectorMatch match = m_checker.checkSelector(context, m_dynamicPseudo);
> +    SelectorChecker::SelectorMatch match = m_selectorChecker.checkSelector(context, m_dynamicPseudo);

To reduce redundancy it would also be nice to remove the word 'selector' from the SelectorChecker methods.
Comment 6 Antti Koivisto 2012-12-30 00:38:22 PST 
...and enums too

SelectorChecker::SelectorMatch -> SelectorChecker::Match
Comment 7 Dimitri Glazkov (Google) 2013-01-08 21:06:39 PST 
(In reply to comment #6)
> ...and enums too
> 
> SelectorChecker::SelectorMatch -> SelectorChecker::Match

Good idea! See bug 106413.