RESOLVED FIXED 106413
The word "selector" is somewhat redundant redundantly used in SelectorChecker. 
https://bugs.webkit.org/show_bug.cgi?id=106413
Summary The word "selector" is somewhat redundant redundantly used in SelectorChecker.
Dimitri Glazkov (Google)
Reported 2013-01-08 21:02:48 PST
The word "selector" is somewhat redundant redundantly used in SelectorChecker.
Attachments
Patch (17.46 KB, patch)
2013-01-08 21:05 PST, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
Patch for landing (17.46 KB, patch)
2013-01-10 21:40 PST, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2013-01-08 21:05:15 PST
Created attachment 181837 [details] Patch
Build Bot
Comment 2 2013-01-08 21:18:57 PST
Comment on attachment 181837 [details] Patch Attachment 181837 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/15754580
Build Bot
Comment 3 2013-01-08 21:19:55 PST
Comment on attachment 181837 [details] Patch Attachment 181837 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15762353
Antti Koivisto
Comment 4 2013-01-09 03:38:14 PST
Comment on attachment 181837 [details] Patch LGTM, not sure why it is not building on Mac.
Dimitri Glazkov (Google)
Comment 5 2013-01-09 09:47:25 PST
(In reply to comment #4) > LGTM, not sure why it is not building on Mac. will fix.
Dimitri Glazkov (Google)
Comment 6 2013-01-09 20:04:25 PST
It's weird. The error makes it sound like there's a macro check(X) that's defined somewhere.
Antti Koivisto
Comment 7 2013-01-10 00:51:03 PST
/usr/include/AssertMacros.h #ifndef __ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORES /* If we haven't set this yet, it defaults to on. In the next release, this will default to off. */ #define __ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORES 1 #endif #if __ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORES #ifndef check #define check(assertion) __Check(assertion) #endif ... Lame. Hmm, how about naming them match() instead? Might even read better.
Allan Sandfeld Jensen
Comment 8 2013-01-10 01:32:19 PST
Does really improve the naming? I admit SelectorChecker::checkSelector is a _very_ redundant (even Checker::check() is), but I like that the method name in itself is fully descriptive.
Dimitri Glazkov (Google)
Comment 9 2013-01-10 21:39:50 PST
(In reply to comment #7) > > Hmm, how about naming them match() instead? Might even read better. Sounds good, going with that.
Dimitri Glazkov (Google)
Comment 10 2013-01-10 21:40:10 PST
Created attachment 182262 [details] Patch for landing
WebKit Review Bot
Comment 11 2013-01-10 22:19:58 PST
Comment on attachment 182262 [details] Patch for landing Clearing flags on attachment: 182262 Committed r139406: <http://trac.webkit.org/changeset/139406>
WebKit Review Bot
Comment 12 2013-01-10 22:20:02 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.