Bug 105819 – [Qt] REGRESSION(r138517): It made 2 tests fail

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: New Bugs

[Csaba Osztrogonác]

- http/tests/security/cross-frame-access-put.html
- http/tests/security/sandboxed-iframe-form-top.html

--- /ramdisk/qt-linux-64-release/build/layout-test-results/http/tests/security/cross-frame-access-put-expected.txt 
+++ /ramdisk/qt-linux-64-release/build/layout-test-results/http/tests/security/cross-frame-access-put-actual.txt 
@@ -1,3 +1,5 @@
+CONSOLE MESSAGE: Unsafe JavaScript attempt to initiate navigation for frame with URL 'http://127.0.0.1:8000/security/sandboxed-iframe-form-top.html' from frame with URL 'http://127.0.0.1:8000/security/resources/sandboxed-iframe-form-top.html'. The frame attempting navigation of the top-level window is sandboxed, but the 'allow-top-navigation' flag is not set.
+
 CONSOLE MESSAGE: Unsafe JavaScript attempt to access frame with URL http://127.0.0.1:8000/security/cross-frame-access-put.html from frame with URL http://localhost:8000/security/resources/cross-frame-iframe-for-put-test.html. Domains, protocols and ports must match.
 
 CONSOLE MESSAGE: Unsafe JavaScript attempt to access frame with URL http://localhost:8000/security/resources/cross-frame-iframe-for-put-test.html from frame with URL http://127.0.0.1:8000/security/cross-frame-access-put.html. Domains, protocols and ports must match.


--- /ramdisk/qt-linux-64-release/build/layout-test-results/http/tests/security/sandboxed-iframe-form-top-expected.txt 
+++ /ramdisk/qt-linux-64-release/build/layout-test-results/http/tests/security/sandboxed-iframe-form-top-actual.txt 
@@ -1,4 +1,4 @@
-CONSOLE MESSAGE: Unsafe JavaScript attempt to initiate a navigation change for frame with URL http://127.0.0.1:8000/security/sandboxed-iframe-form-top.html from frame with URL http://127.0.0.1:8000/security/resources/sandboxed-iframe-form-top.html.
+CONSOLE MESSAGE: Unsafe JavaScript attempt to initiate navigation for frame with URL 'http://127.0.0.1:8000/security/sandboxed-iframe-form-top.html' from frame with URL 'http://127.0.0.1:8000/security/resources/sandboxed-iframe-form-top.html'. The frame attempting navigation of the top-level window is sandboxed, but the 'allow-top-navigation' flag is not set.
 
 This tests passes if the sandboxed frame cannot navigate the top frame.

[Mike West]

Should just need a rebaseline. I'll take care of it this afternoon when I'm in front of a computer again.

[Csaba Osztrogonác]

I can't and I won't check and fix any bug/regression in my holiday,
I can do only the fire-fighting, so I skipped these tests to paint
the bots green and let the others fixing the bug - r138525.

And please don't forget unskipping them with the proper fix.

[Mike West]

Actually, this looks like a duplicate of 85522. `sandboxed-iframe-form-top.html` isn't causing problems on other platforms only because it's skipped. :)

Moving the expectations around, and I'll close this as a dupe.

[Mike West]

Created attachment 180874 [details]
Patch

[Mike West]

Comment on attachment 180874 [details]
Patch

Failed to apply on gtk.

[Mike West]

Comment on attachment 180874 [details]
Patch

Hrm. Trying again, I think the GTK EWS bot is simply unhappy.

[WebKit Review Bot]

Comment on attachment 180874 [details]
Patch

Clearing flags on attachment: 180874

Committed r138535: <http://trac.webkit.org/changeset/138535>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Mike West]

*** This bug has been marked as a duplicate of bug 85522 ***