Bug 105481 - Implement ID selector matching for the WebVTT ::cue pseudo element
Summary: Implement ID selector matching for the WebVTT ::cue pseudo element
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on: 105480
Blocks: 43668 106762
  Show dependency tree / graph
 
Reported: 2012-12-19 16:54 PST by Dima Gorbik
Modified: 2013-01-14 21:24 PST (History)
7 users (show)

See Also:

Attachments
Proposed fix 0.1 (1.95 KB, patch)
2012-12-20 19:30 PST, Dima Gorbik 		no flags Details | Formatted Diff | Diff
Proposed fix 0.2 (6.80 KB, patch)
2013-01-13 23:14 PST, Dima Gorbik 		eric.carlson: review+
Details | Formatted Diff | Diff
Proposed fix 0.2 (7.24 KB, patch)
2013-01-14 18:28 PST, Dima Gorbik 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dima Gorbik 2012-12-19 16:54:13 PST 
More information: http://dev.w3.org/html5/webvtt/#the-'::cue'-pseudo-element
Comment 1 Radar WebKit Bug Importer 2012-12-19 16:55:09 PST 
<rdar://problem/12914622>
Comment 2 Dima Gorbik 2012-12-20 19:30:10 PST 
Created attachment 180459 [details]
Proposed fix 0.1

This patch adds support for cue ID matching and also voice attribute matching for the WebVTT CSS extensions.
I will add layout tests after the previous patch is being reviewed (https://bugs.webkit.org/show_bug.cgi?id=105473) because they will be based on the existing layout tests from that patch.
Comment 3 Dima Gorbik 2013-01-13 23:14:13 PST 
Created attachment 182515 [details]
Proposed fix 0.2
Comment 4 Eric Carlson 2013-01-14 08:41:04 PST 
Comment on attachment 182515 [details]
Proposed fix 0.2

View in context: https://bugs.webkit.org/attachment.cgi?id=182515&action=review

> LayoutTests/media/track/track-css-matching.html:54
>                  consoleWrite("");
>                  consoleWrite("");

Nit: two blank lines can be added with consoleWrite("<br>");
Comment 5 Dima Gorbik 2013-01-14 18:28:06 PST 
Created attachment 182675 [details]
Proposed fix 0.2
Comment 6 WebKit Review Bot 2013-01-14 21:24:09 PST 
Comment on attachment 182675 [details]
Proposed fix 0.2

Clearing flags on attachment: 182675

Committed r139714: <http://trac.webkit.org/changeset/139714>
Comment 7 WebKit Review Bot 2013-01-14 21:24:13 PST 
All reviewed patches have been landed.  Closing bug.