Bug 105326 - [WebGL][EFL][Qt][GTK] Jelly fishes leave trails on webgl canvas.
Summary: [WebGL][EFL][Qt][GTK] Jelly fishes leave trails on webgl canvas.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Viatcheslav Ostapenko
URL:
Keywords:
: 100920 (view as bug list)
Depends on:
Blocks: 104664
  Show dependency treegraph
 
Reported: 2012-12-18 10:44 PST by Viatcheslav Ostapenko
Modified: 2013-01-10 20:37 PST (History)
6 users (show)

See Also:


Attachments
Jelly fishes with trails. (102.34 KB, image/jpeg)
2012-12-18 10:44 PST, Viatcheslav Ostapenko
no flags Details
Patch (4.46 KB, patch)
2012-12-20 19:38 PST, Dongseong Hwang
no flags Details | Formatted Diff | Diff
Patch (4.06 KB, patch)
2012-12-20 20:31 PST, Dongseong Hwang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Viatcheslav Ostapenko 2012-12-18 10:44:08 PST
Created attachment 179978 [details]
Jelly fishes with trails.

Page url: http://aleksandarrodic.com/p/jellyfish/
Seems canvas has to be cleared between frames.
Picture attached.
Comment 1 Dongseong Hwang 2012-12-20 19:02:45 PST
I posted detail info in irrelevant Bug 105325.

http://www.khronos.org/registry/webgl/specs/latest/#2.2
WebGL require clearing a drawing buffer after compositing. It's interesting.

copied from https://bugs.webkit.org/show_bug.cgi?id=105325#c2
Comment 2 Dongseong Hwang 2012-12-20 19:38:35 PST
Created attachment 180463 [details]
Patch
Comment 3 Viatcheslav Ostapenko 2012-12-20 19:48:33 PST
Comment on attachment 180463 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180463&action=review

> Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.cpp:121
> +    m_context->markLayerComposited();

Why do you put it here still keeping notImplemented() ?
Comment 4 Dongseong Hwang 2012-12-20 20:12:39 PST
Comment on attachment 180463 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180463&action=review

>> Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.cpp:121
>> +    m_context->markLayerComposited();
> 
> Why do you put it here still keeping notImplemented() ?

It is because paintToTextureMapper() is not implemented yet. I just put just one of all requirements of paintToTextureMapper().
Do you think removing notImplemented() is better?
Comment 5 Noam Rosenthal 2012-12-20 20:15:52 PST
(In reply to comment #4)
> (From update of attachment 180463 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=180463&action=review
> 
> >> Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.cpp:121
> >> +    m_context->markLayerComposited();
> > 
> > Why do you put it here still keeping notImplemented() ?
> 
> It is because paintToTextureMapper() is not implemented yet. I just put just one of all requirements of paintToTextureMapper().
> Do you think removing notImplemented() is better?

I think not adding markLayerComposited there is better. If it's not implemented it's not implemented :)
Comment 6 Dongseong Hwang 2012-12-20 20:30:17 PST
(In reply to comment #5)
> (In reply to comment #4)
> > (From update of attachment 180463 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=180463&action=review
> > 
> > >> Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.cpp:121
> > >> +    m_context->markLayerComposited();
> > > 
> > > Why do you put it here still keeping notImplemented() ?
> > 
> > It is because paintToTextureMapper() is not implemented yet. I just put just one of all requirements of paintToTextureMapper().
> > Do you think removing notImplemented() is better?
> 
> I think not adding markLayerComposited there is better. If it's not implemented it's not implemented :)

Yeah, I'll post again. :)
Comment 7 Dongseong Hwang 2012-12-20 20:31:52 PST
Created attachment 180469 [details]
Patch
Comment 8 Dongseong Hwang 2012-12-20 20:34:48 PST
(In reply to comment #7)
> Created an attachment (id=180469) [details]
> Patch

Thank you for review!

noam, I'm not committer yet. could you cq+? :)
Comment 9 WebKit Review Bot 2012-12-20 21:09:58 PST
Comment on attachment 180469 [details]
Patch

Clearing flags on attachment: 180469

Committed r138346: <http://trac.webkit.org/changeset/138346>
Comment 10 WebKit Review Bot 2012-12-20 21:10:03 PST
All reviewed patches have been landed.  Closing bug.
Comment 11 Dongseong Hwang 2013-01-10 20:37:59 PST
*** Bug 100920 has been marked as a duplicate of this bug. ***