Callers should not have to stringify args before calling Executive run_command/popen
Created attachment 179373 [details] Patch
%test-webkitpy Suppressing most webkitpy logging while running unit tests. Skipping tests in the following modules or packages because they are really, really, slow: webkitpy.common.checkout.scm.scm_unittest (https://bugs.webkit.org/show_bug.cgi?id=31818; use --all to include) [99/1610] webkitpy.common.checkout.baselineoptimizer_unittest.BaselineOptimizerTest.test_chromium_covers_mac_win_linux (+10)Failure: No such entity Failure: No such entity Failure: No such entity Ran 1610 tests in 3.019s OK
Comment on attachment 179373 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179373&action=review Can you verify that NRWT actually runs w/ this patch, since it broke last time trying to start the http server? > Tools/Scripts/webkitpy/common/system/executive.py:390 > + args = self._stringify_args(args) You can probably now simplify _command_for_printing(), yes?
Comment on attachment 179373 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179373&action=review >> Tools/Scripts/webkitpy/common/system/executive.py:390 >> + args = self._stringify_args(args) > > You can probably now simplify _command_for_printing(), yes? You mean because I can now always assume unicode? (It turns out we always could before too.)
(In reply to comment #4) > (From update of attachment 179373 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=179373&action=review > > >> Tools/Scripts/webkitpy/common/system/executive.py:390 > >> + args = self._stringify_args(args) > > > > You can probably now simplify _command_for_printing(), yes? > > You mean because I can now always assume unicode? (It turns out we always could before too.) yes.
Created attachment 179380 [details] Patch
Comment on attachment 179380 [details] Patch ok.
Comment on attachment 179380 [details] Patch Clearing flags on attachment: 179380 Committed r137692: <http://trac.webkit.org/changeset/137692>
All reviewed patches have been landed. Closing bug.