Bug 104975 - Callers should not have to stringify args before calling Executive run_command/popen
Summary: Callers should not have to stringify args before calling Executive run_comman...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks: 104891
  Show dependency treegraph
 
Reported: 2012-12-13 16:32 PST by Eric Seidel (no email)
Modified: 2012-12-13 17:59 PST (History)
3 users (show)

See Also:


Attachments
Patch (5.38 KB, patch)
2012-12-13 16:35 PST, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff
Patch (6.31 KB, patch)
2012-12-13 17:08 PST, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2012-12-13 16:32:31 PST
Callers should not have to stringify args before calling Executive run_command/popen
Comment 1 Eric Seidel (no email) 2012-12-13 16:35:29 PST
Created attachment 179373 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-12-13 16:36:13 PST
%test-webkitpy
Suppressing most webkitpy logging while running unit tests.
Skipping tests in the following modules or packages because they are really, really, slow:
    webkitpy.common.checkout.scm.scm_unittest
    (https://bugs.webkit.org/show_bug.cgi?id=31818; use --all to include)

[99/1610] webkitpy.common.checkout.baselineoptimizer_unittest.BaselineOptimizerTest.test_chromium_covers_mac_win_linux (+10)Failure: No such entity
Failure: No such entity
Failure: No such entity
Ran 1610 tests in 3.019s                                                                                                    

OK
Comment 3 Dirk Pranke 2012-12-13 16:43:58 PST
Comment on attachment 179373 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=179373&action=review

Can you verify that NRWT actually runs w/ this patch, since it broke last time trying to start the http server?

> Tools/Scripts/webkitpy/common/system/executive.py:390
> +        args = self._stringify_args(args)

You can probably now simplify _command_for_printing(), yes?
Comment 4 Eric Seidel (no email) 2012-12-13 16:47:48 PST
Comment on attachment 179373 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=179373&action=review

>> Tools/Scripts/webkitpy/common/system/executive.py:390
>> +        args = self._stringify_args(args)
> 
> You can probably now simplify _command_for_printing(), yes?

You mean because I can now always assume unicode?  (It turns out we always could before too.)
Comment 5 Dirk Pranke 2012-12-13 16:50:25 PST
(In reply to comment #4)
> (From update of attachment 179373 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=179373&action=review
> 
> >> Tools/Scripts/webkitpy/common/system/executive.py:390
> >> +        args = self._stringify_args(args)
> > 
> > You can probably now simplify _command_for_printing(), yes?
> 
> You mean because I can now always assume unicode?  (It turns out we always could before too.)

yes.
Comment 6 Eric Seidel (no email) 2012-12-13 17:08:24 PST
Created attachment 179380 [details]
Patch
Comment 7 Dirk Pranke 2012-12-13 17:11:23 PST
Comment on attachment 179380 [details]
Patch

ok.
Comment 8 WebKit Review Bot 2012-12-13 17:59:07 PST
Comment on attachment 179380 [details]
Patch

Clearing flags on attachment: 179380

Committed r137692: <http://trac.webkit.org/changeset/137692>
Comment 9 WebKit Review Bot 2012-12-13 17:59:11 PST
All reviewed patches have been landed.  Closing bug.