Bug 104952 - URL duplication in mouse cursor tests mean minor typos can cause flakiness
Summary: URL duplication in mouse cursor tests mean minor typos can cause flakiness
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rick Byers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-13 14:12 PST by Rick Byers
Modified: 2013-01-04 14:46 PST (History)
3 users (show)

See Also:


Attachments
Patch (14.89 KB, patch)
2012-12-21 07:32 PST, Rick Byers
no flags Details | Formatted Diff | Diff
Fix mac failure (15.17 KB, patch)
2012-12-21 12:50 PST, Rick Byers
no flags Details | Formatted Diff | Diff
Patch for landing (15.18 KB, patch)
2013-01-04 13:30 PST, Rick Byers
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rick Byers 2012-12-13 14:12:37 PST
In bug 104945 we saw flakiness in one of my mouse cursor tests as a result of a typo in one of the two copies of a URL.  It sucks that accidentally missing or mistyping one of the URLs in the preload list leads to random flakiness instead of a deterministic failure.   I need to come up with some way to fix this - ideally by having only a single list of URLs that need to be preloaded.
Comment 1 Rick Byers 2012-12-21 07:32:54 PST
Created attachment 180520 [details]
Patch
Comment 2 Rick Byers 2012-12-21 07:33:34 PST
Comment on attachment 180520 [details]
Patch

I think this approach is a better trade-off between simplicity and brittleness.  Eric, what do you think?
Comment 3 Build Bot 2012-12-21 08:00:46 PST
Comment on attachment 180520 [details]
Patch

Attachment 180520 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15454435

New failing tests:
fast/events/mouse-cursor-multiframecur.html
Comment 4 Rick Byers 2012-12-21 12:50:44 PST
Created attachment 180546 [details]
Fix mac failure
Comment 5 Rick Byers 2013-01-04 11:56:12 PST
Ping - eric, do you want to review this?
Comment 6 Eric Seidel (no email) 2013-01-04 12:55:25 PST
Comment on attachment 180546 [details]
Fix mac failure

Very cool.
Comment 7 WebKit Review Bot 2013-01-04 13:11:59 PST
Comment on attachment 180546 [details]
Fix mac failure

Rejecting attachment 180546 [details] from commit-queue.

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', u'--status-host=queues.webkit.org', ..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue

/mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/15700236
Comment 8 Rick Byers 2013-01-04 13:30:18 PST
Created attachment 181368 [details]
Patch for landing
Comment 9 WebKit Review Bot 2013-01-04 14:46:48 PST
Comment on attachment 181368 [details]
Patch for landing

Clearing flags on attachment: 181368

Committed r138857: <http://trac.webkit.org/changeset/138857>
Comment 10 WebKit Review Bot 2013-01-04 14:46:52 PST
All reviewed patches have been landed.  Closing bug.