RESOLVED FIXED104952
URL duplication in mouse cursor tests mean minor typos can cause flakiness 
https://bugs.webkit.org/show_bug.cgi?id=104952
Summary URL duplication in mouse cursor tests mean minor typos can cause flakiness
Rick Byers
Reported 2012-12-13 14:12:37 PST
In bug 104945 we saw flakiness in one of my mouse cursor tests as a result of a typo in one of the two copies of a URL. It sucks that accidentally missing or mistyping one of the URLs in the preload list leads to random flakiness instead of a deterministic failure. I need to come up with some way to fix this - ideally by having only a single list of URLs that need to be preloaded.
Attachments
Patch (14.89 KB, patch)
2012-12-21 07:32 PST, Rick Byers 		no flags
DetailsFormatted DiffDiff
Fix mac failure (15.17 KB, patch)
2012-12-21 12:50 PST, Rick Byers 		no flags
DetailsFormatted DiffDiff
Patch for landing (15.18 KB, patch)
2013-01-04 13:30 PST, Rick Byers 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Rick Byers
Comment 1 2012-12-21 07:32:54 PST
Created attachment 180520 [details] Patch
Rick Byers
Comment 2 2012-12-21 07:33:34 PST
Comment on attachment 180520 [details] Patch I think this approach is a better trade-off between simplicity and brittleness. Eric, what do you think?
Build Bot
Comment 3 2012-12-21 08:00:46 PST
Comment on attachment 180520 [details] Patch Attachment 180520 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15454435 New failing tests: fast/events/mouse-cursor-multiframecur.html
Rick Byers
Comment 4 2012-12-21 12:50:44 PST
Created attachment 180546 [details] Fix mac failure
Rick Byers
Comment 5 2013-01-04 11:56:12 PST
Ping - eric, do you want to review this?
Eric Seidel (no email)
Comment 6 2013-01-04 12:55:25 PST
Comment on attachment 180546 [details] Fix mac failure Very cool.
WebKit Review Bot
Comment 7 2013-01-04 13:11:59 PST
Comment on attachment 180546 [details] Fix mac failure Rejecting attachment 180546 [details] from commit-queue. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', u'--status-host=queues.webkit.org', ..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/15700236
Rick Byers
Comment 8 2013-01-04 13:30:18 PST
Created attachment 181368 [details] Patch for landing
WebKit Review Bot
Comment 9 2013-01-04 14:46:48 PST
Comment on attachment 181368 [details] Patch for landing Clearing flags on attachment: 181368 Committed r138857: <http://trac.webkit.org/changeset/138857>
WebKit Review Bot
Comment 10 2013-01-04 14:46:52 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.