Bug 104945 - Layout Test fast/events/mouse-cursor-image-set.html is flaky
Summary: Layout Test fast/events/mouse-cursor-image-set.html is flaky
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rick Byers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-13 13:34 PST by Eric Seidel (no email)
Modified: 2012-12-13 16:43 PST (History)
3 users (show)

See Also:


Attachments
Patch (1.54 KB, patch)
2012-12-13 16:05 PST, Rick Byers
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2012-12-13 13:34:03 PST
The following layout test is flaky on all (chromium?) platforms

fast/events/mouse-cursor-image-set.html
http://trac.webkit.org/browser/trunk/LayoutTests/fast/events/mouse-cursor-image-set.html

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=fast%2Fevents%2Fmouse-cursor-image-set.html

This test has only been around for 7 days.
Comment 1 Eric Seidel (no email) 2012-12-13 13:35:25 PST
I'm not sure if it's an image loading issue:
 TEST CASE: Implicit hot-spot at (5,4) physical for 1x and (28,3) physical for 2x
-Cursor Info: type=Custom hotSpot=5,4 image=25x25
+Cursor Info: type=Custom hotSpot=0,0 image=0x0

it always seems to fail the same subtest.
Comment 2 Eric Seidel (no email) 2012-12-13 13:37:42 PST
I think it's this typo here:
 { url: 'resources/greenbox-hotspot35-4.cur' },

the '3'.

The loading system seems fragile.  Maybe we could read those images from the CSS values?
Comment 3 Rick Byers 2012-12-13 13:59:39 PST
I'll look into this.  Yes if the test fails to reliably preload one of the images then it can get output like this.  Ideally I'd be able to assert that an image was already preloaded or something.  And yes I thought about trying to combine the lists to avoid duplication and risk of inconsistency but I didn't come up with anything that was clean and simple.  I'll re-evaluate.  Let me know if you have any suggestions.
Comment 4 Rick Byers 2012-12-13 14:07:05 PST
Dammit, and yes this is just a typo or copy-paste error with 'hotspot35-4' that should be 'hotspot5-4', dammit - sorry about that.

I'll submit a trivial fix now, and file a separate bug to improve the infrastructure to make such mismatches impossible (which I probably won't get to until next week since I'm travelling this week).
Comment 5 Rick Byers 2012-12-13 14:12:57 PST
Underlying issue tracked in bug 104952
Comment 6 Rick Byers 2012-12-13 16:05:27 PST
Created attachment 179363 [details]
Patch
Comment 7 Eric Seidel (no email) 2012-12-13 16:11:53 PST
Comment on attachment 179363 [details]
Patch

Thank you Rick and Beth!
Comment 8 Rick Byers 2012-12-13 16:42:26 PST
(In reply to comment #7)
> (From update of attachment 179363 [details])
> Thank you Rick and Beth!

Thank you for noticing and ccing me!  I wish we had a way for test owners to be auto-notified of any failures.
Comment 9 WebKit Review Bot 2012-12-13 16:43:33 PST
Comment on attachment 179363 [details]
Patch

Clearing flags on attachment: 179363

Committed r137684: <http://trac.webkit.org/changeset/137684>
Comment 10 WebKit Review Bot 2012-12-13 16:43:36 PST
All reviewed patches have been landed.  Closing bug.