WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
104883
Regression(
r137486
): Broke EFL build
https://bugs.webkit.org/show_bug.cgi?id=104883
Summary
Regression(r137486): Broke EFL build
Chris Dumez
Reported
2012-12-13 00:02:31 PST
http://trac.webkit.org/changeset/137486
broke the EFL build: [ 86%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/UIProcess/WebDatabaseManagerProxy.cpp.o /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Tools/DumpRenderTree/efl/TestRunnerEfl.cpp: In member function ‘void TestRunner::addDisallowedURL(JSStringRef)’: /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Tools/DumpRenderTree/efl/TestRunnerEfl.cpp:71:276: error: ‘notImplementedLoggingChannel’ was not declared in this scope /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Tools/DumpRenderTree/efl/TestRunnerEfl.cpp:71:276: note: suggested alternative:
Attachments
Patch
(1.44 KB, patch)
2012-12-13 00:05 PST
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2012-12-13 00:05:36 PST
Created
attachment 179213
[details]
Patch
Eric Seidel (no email)
Comment 2
2012-12-13 00:10:19 PST
LGTM.
Chris Dumez
Comment 3
2012-12-13 00:30:38 PST
Committed
r137572
: <
http://trac.webkit.org/changeset/137572
>
Alexey Proskuryakov
Comment 4
2012-12-13 08:36:06 PST
Thank you for fixing this!
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug