Bug 104718 - Make LOG() work in WebProcess and NetworkProcess
Summary: Make LOG() work in WebProcess and NetworkProcess
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on: 104883
Blocks:
  Show dependency treegraph
 
Reported: 2012-12-11 14:07 PST by Alexey Proskuryakov
Modified: 2012-12-13 00:06 PST (History)
17 users (show)

See Also:


Attachments
proposed fix (3.46 KB, patch)
2012-12-11 14:13 PST, Alexey Proskuryakov
andersca: review+
Details | Formatted Diff | Diff
proposed fix (26.28 KB, patch)
2012-12-11 15:09 PST, Alexey Proskuryakov
webkit-ews: commit-queue-
Details | Formatted Diff | Diff
with release build fix (26.60 KB, patch)
2012-12-11 15:21 PST, Alexey Proskuryakov
thorton: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
patch for landing with multiple port fixes (33.21 KB, patch)
2012-12-11 16:12 PST, Alexey Proskuryakov
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
patch for landing (33.14 KB, patch)
2012-12-12 09:54 PST, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2012-12-11 14:07:15 PST
NetworkProcess doesn't initialize any logging at all. WebProcess initializes WebCore logging only, but not WebKit2 channels.
Comment 1 Alexey Proskuryakov 2012-12-11 14:13:38 PST
Created attachment 178872 [details]
proposed fix
Comment 2 Alexey Proskuryakov 2012-12-11 15:09:06 PST
Created attachment 178887 [details]
proposed fix

Thanks to thorton's vigilance, the patch is now a little larger.
Comment 3 Alexey Proskuryakov 2012-12-11 15:11:50 PST
Comment on attachment 178887 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=178887&action=review

> Source/WebKit2/NetworkProcess/NetworkProcess.cpp:104
> +    WebKit::initializeLogChannelsIfNecessary();

Should initialize WebCore logging here, too.
Comment 4 Early Warning System Bot 2012-12-11 15:14:58 PST
Comment on attachment 178887 [details]
proposed fix

Attachment 178887 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/15282207
Comment 5 Early Warning System Bot 2012-12-11 15:17:21 PST
Comment on attachment 178887 [details]
proposed fix

Attachment 178887 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/15277324
Comment 6 Alexey Proskuryakov 2012-12-11 15:21:29 PST
Created attachment 178891 [details]
with release build fix
Comment 7 Build Bot 2012-12-11 15:49:29 PST
Comment on attachment 178891 [details]
with release build fix

Attachment 178891 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/15285037
Comment 8 Alexey Proskuryakov 2012-12-11 16:12:51 PST
Created attachment 178909 [details]
patch for landing with multiple port fixes
Comment 9 WebKit Review Bot 2012-12-11 17:53:32 PST
Comment on attachment 178909 [details]
patch for landing with multiple port fixes

Rejecting attachment 178909 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 13185 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
52>At revision 13185.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/15277387
Comment 10 Build Bot 2012-12-12 03:53:29 PST
Comment on attachment 178909 [details]
patch for landing with multiple port fixes

Attachment 178909 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15282464
Comment 11 Alexey Proskuryakov 2012-12-12 09:54:45 PST
Created attachment 179072 [details]
patch for landing
Comment 12 WebKit Review Bot 2012-12-12 11:08:36 PST
Comment on attachment 179072 [details]
patch for landing

Clearing flags on attachment: 179072

Committed r137486: <http://trac.webkit.org/changeset/137486>
Comment 13 WebKit Review Bot 2012-12-12 11:08:43 PST
All reviewed patches have been landed.  Closing bug.
Comment 14 Eric Seidel (no email) 2012-12-12 11:52:45 PST
I think this broke cr-linux:
../../Source/WebCore/platform/NotImplemented.cpp: In function ‘void logNotImplemented()’:
../../Source/WebCore/platform/NotImplemented.cpp:32:16: error: ‘printf’ was not declared in this scope

But should be an easy fix.
Comment 15 Eric Seidel (no email) 2012-12-12 11:54:22 PST
Actually, that whole file looks wrong.  Must have been a mistaken commit.  I'm not sure from this bug, since I saw ossy comment about this in another bug... /me goes to look.
Comment 16 Alexey Proskuryakov 2012-12-12 12:08:17 PST
That was from a different commit, which got reverted a moment ago anyway.
Comment 17 Chris Dumez 2012-12-12 23:57:19 PST
Comment on attachment 179072 [details]
patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=179072&action=review

> Source/WebCore/platform/NotImplemented.h:51
> +            WTFLogVerbose(__FILE__, __LINE__, WTF_PRETTY_FUNCTION, notImplementedLoggingChannel(), "UNIMPLEMENTED: "); \

Why no WebCore:: namespace for notImplementedLoggingChannel() ? This causes a build break on EFL port. Is it mandatory for the caller to use "using namespace WebCore;" ?
Comment 18 Tim Horton 2012-12-13 00:00:45 PST
(In reply to comment #17)
> (From update of attachment 179072 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=179072&action=review
> 
> > Source/WebCore/platform/NotImplemented.h:51
> > +            WTFLogVerbose(__FILE__, __LINE__, WTF_PRETTY_FUNCTION, notImplementedLoggingChannel(), "UNIMPLEMENTED: "); \
> 
> Why no WebCore:: namespace for notImplementedLoggingChannel() ? This causes a build break on EFL port. Is it mandatory for the caller to use "using namespace WebCore;" ?

I think adding the WebCore:: here is more reasonable than silently forcing callers to import the namespace.
Comment 19 Chris Dumez 2012-12-13 00:06:18 PST
(In reply to comment #18)
> (In reply to comment #17)
> > (From update of attachment 179072 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=179072&action=review
> > 
> > > Source/WebCore/platform/NotImplemented.h:51
> > > +            WTFLogVerbose(__FILE__, __LINE__, WTF_PRETTY_FUNCTION, notImplementedLoggingChannel(), "UNIMPLEMENTED: "); \
> > 
> > Why no WebCore:: namespace for notImplementedLoggingChannel() ? This causes a build break on EFL port. Is it mandatory for the caller to use "using namespace WebCore;" ?
> 
> I think adding the WebCore:: here is more reasonable than silently forcing callers to import the namespace.

Yes I agree, I'm fixing this in https://bugs.webkit.org/show_bug.cgi?id=104883