Bug 104880 - Coordinated Graphics: Small refactor of CoordinatedLayerTreeHost and CoordinatedGraphicsLayer.
Summary: Coordinated Graphics: Small refactor of CoordinatedLayerTreeHost and Coordina...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dongseong Hwang
URL:
Keywords:
Depends on:
Blocks: 103959
  Show dependency tree / graph
 
Reported: 2012-12-12 22:27 PST by Dongseong Hwang
Modified: 2012-12-16 18:29 PST (History)
4 users (show)

See Also:

Attachments
Patch : This patch changes two points. (3.79 KB, patch)
2012-12-12 22:47 PST, Dongseong Hwang 		no flags Details | Formatted Diff | Diff
Patch : Delete backing stores explicitly in ~CoordinatedLayerTreeHost(). (4.57 KB, patch)
2012-12-12 23:12 PST, Dongseong Hwang 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dongseong Hwang 2012-12-12 22:27:29 PST 
This patch chages two points.
1. Remove layerByIDMap() in CoordinatedGraphicsLayer because it is unused.
2. Remove code swapping m_registeredLayers in CoordinatedLayerTreeHost because
setCoordinator(0) does not call detachLayer().
Comment 1 Dongseong Hwang 2012-12-12 22:47:04 PST 
Created attachment 179202 [details]
Patch : This patch changes two points.
Comment 2 Dongseong Hwang 2012-12-12 23:12:09 PST 
Created attachment 179206 [details]
Patch : Delete backing stores explicitly in ~CoordinatedLayerTreeHost().
Comment 3 Dongseong Hwang 2012-12-13 16:15:01 PST 
ping.

It blocks Bug 103959
Comment 4 Dongseong Hwang 2012-12-13 18:40:53 PST 
Thanks for review!

Could you review the first patch also?
Comment 5 Noam Rosenthal 2012-12-15 10:16:46 PST 
Comment on attachment 179202 [details]
Patch : This patch changes two points.

Please cq+ in your timezone so that you can follow up if it breaks a bot.
Comment 6 Dongseong Hwang 2012-12-15 19:09:58 PST 
Thank you for review!
Comment 7 WebKit Review Bot 2012-12-16 18:12:24 PST 
Comment on attachment 179206 [details]
Patch : Delete backing stores explicitly in ~CoordinatedLayerTreeHost().

Clearing flags on attachment: 179206

Committed r137863: <http://trac.webkit.org/changeset/137863>
Comment 8 WebKit Review Bot 2012-12-16 18:29:08 PST 
Comment on attachment 179202 [details]
Patch : This patch changes two points.

Clearing flags on attachment: 179202

Committed r137866: <http://trac.webkit.org/changeset/137866>
Comment 9 WebKit Review Bot 2012-12-16 18:29:12 PST 
All reviewed patches have been landed.  Closing bug.