Chromium win release perf bots at webkit.org are mostly always red. http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Perf%29?numbuilds=100 Cause is test DOM/DOMWalk.html, which reports that time goes backwards or some such, on just about every perf test run. Running DOM/DOMWalk.html (35 of 113) runFunction returned a non-positive value: 0 runFunction returned a non-positive value: 0 runFunction returned a non-positive value: 0 runFunction returned a non-positive value: 0 runFunction returned a non-positive value: 0 runFunction returned a non-positive value: 0 FAILED Finished: 9.610000 s The same error is seen on Chromium Linux, though much less often.
yeah, we need to make those tests use window.performance instead.
How do I disable this test (at least until it's fixed by someone who knows this test)? I want green perf bots so I can catch real regressions.
(In reply to comment #2) > How do I disable this test (at least until it's fixed by someone who knows this test)? I want green perf bots so I can catch real regressions. You never catch regressions on webkit perf. bots. Bots run red iff tests fail to complete as expected. It doesn’t catch perf regressions. To do that, you have to look at graphs on webkit-perf.appspot.com
/meh I want green perf bots.
(In reply to comment #4) > /meh I want green perf bots. so, how do I disable this test?
We don't have a way of skipping a test on one platform. If you want a green bot, please either fix the test or Date.now implementation. I'll try to look into it in the next couple of days in my spare time but don't count on me.
Created attachment 179237 [details] Hopefully fixes the bug
*** Bug 99432 has been marked as a duplicate of this bug. ***
Comment on attachment 179237 [details] Hopefully fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=179237&action=review > PerformanceTests/ChangeLog:3 > + [chromium perf] DOM/DOMWalk.html failures Thank you, LGTM.
Comment on attachment 179237 [details] Hopefully fixes the bug Fancy
Comment on attachment 179237 [details] Hopefully fixes the bug Clearing flags on attachment: 179237 Committed r137623: <http://trac.webkit.org/changeset/137623>
All reviewed patches have been landed. Closing bug.
This test is still failing on Chromium Windows. Someone needs to debug this.
Also see https://bugs.webkit.org/show_bug.cgi?id=105491.
*** This bug has been marked as a duplicate of bug 102500 ***