Bug 104822 – Implement CSSSupportsRule

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Pablo Flouret]

http://dev.w3.org/csswg/css3-conditional/#the-csssupportsrule-interface

Right now @supports is not creating CSSSupportRules, so they don't show up in the stylesheets' cssRules, and also creates problems like the one in http://hg.csswg.org/test/file/5f94e4b03ed9/contributors/opera/submitted/css3-conditional/at-supports-004.html Namely, @support rules declared within @media are applied whether the media query applies or not.

[Pablo Flouret]

Created attachment 180389 [details]
Patch

[WebKit Review Bot]

Attachment 180389 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/css3..." exit_code: 1
Source/WebCore/css/RuleSet.cpp:326:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/css/CSSRule.h:54:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/css/CSSPropertySourceData.h:100:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/css/CSSPropertySourceData.h:101:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 4 in 43 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Comment on attachment 180389 [details]
Patch

Attachment 180389 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/15454123

[Early Warning System Bot]

Comment on attachment 180389 [details]
Patch

Attachment 180389 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/15462039

[WebKit Review Bot]

Comment on attachment 180389 [details]
Patch

Attachment 180389 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15451149

[Build Bot]

Comment on attachment 180389 [details]
Patch

Attachment 180389 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/15445209

[Peter Beverloo (cr-android ews)]

Comment on attachment 180389 [details]
Patch

Attachment 180389 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/15464033

[Pablo Flouret]

Created attachment 180402 [details]
Patch

Missed some ENABLE guards, sorry for the noise.

[WebKit Review Bot]

Attachment 180402 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/css3..." exit_code: 1
Source/WebCore/css/RuleSet.cpp:326:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/css/CSSRule.h:54:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/css/CSSPropertySourceData.h:100:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/css/CSSPropertySourceData.h:101:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 4 in 43 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Allan Sandfeld Jensen]

Comment on attachment 180402 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180402&action=review

> Source/WebCore/ChangeLog:15
> +        This patch also incidentally adds support for proper nesting of at-rules
> +        where allowed by the spec.

Would it make sense to land the part about nesting at-rules as a separate patch, so this patch only addresses the support of support-rules?

>> Source/WebCore/css/RuleSet.cpp:326
>> +        else if (isWithinNestedRule && rule->isImportRule()) {
>> +            // Ignore.
>> +        }
> 
> One line control clauses should not use braces.  [whitespace/braces] [4]

Ignore? Why make the test then?

[Pablo Flouret]

(In reply to comment #10)
> (From update of attachment 180402 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=180402&action=review
> 
> > Source/WebCore/ChangeLog:15
> > +        This patch also incidentally adds support for proper nesting of at-rules
> > +        where allowed by the spec.
> 
> Would it make sense to land the part about nesting at-rules as a separate patch, so this patch only addresses the support of support-rules?
>

Sure.

> >> Source/WebCore/css/RuleSet.cpp:326
> >> +        else if (isWithinNestedRule && rule->isImportRule()) {
> >> +            // Ignore.
> >> +        }
> > 
> > One line control clauses should not use braces.  [whitespace/braces] [4]
> 
> Ignore? Why make the test then?

To make it explicit, but i can get rid of it.

[Pablo Flouret]

Created attachment 182622 [details]
Patch

[WebKit Review Bot]

Attachment 182622 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/css3..." exit_code: 1
Source/WebCore/css/CSSRule.h:54:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/css/CSSPropertySourceData.h:100:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/css/CSSPropertySourceData.h:101:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 3 in 42 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Comment on attachment 182622 [details]
Patch

Attachment 182622 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/15860648

[Early Warning System Bot]

Comment on attachment 182622 [details]
Patch

Attachment 182622 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/15841632

[WebKit Review Bot]

Comment on attachment 182622 [details]
Patch

Attachment 182622 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15860645

[Pablo Flouret]

Created attachment 182627 [details]
Patch

[WebKit Review Bot]

Attachment 182627 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/css3..." exit_code: 1
Source/WebCore/css/CSSRule.h:54:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/css/CSSPropertySourceData.h:100:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/css/CSSPropertySourceData.h:101:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 3 in 42 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Review Bot]

Comment on attachment 182627 [details]
Patch

Clearing flags on attachment: 182627

Committed r139866: <http://trac.webkit.org/changeset/139866>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Simon Fraser (smfr)]

This messed up the Mac Xcode project by adding CSSSupportsRule.h and JSCSSSupportsRule.h to the compile build phase.

[Simon Fraser (smfr)]

Also caused:
ld: warning: ignoring undefined symbol .objc_class_name_DOMCSSSupportsRule from -exported_symbols_list

[Pablo Flouret]

(In reply to comment #21)
> This messed up the Mac Xcode project by adding CSSSupportsRule.h and JSCSSSupportsRule.h to the compile build phase.

I'll check it out.

[Pablo Flouret]

Patch for the warnings at bug 107056.