Bug 107056 - Fix mac build system warnings introduced by r139866
Summary: Fix mac build system warnings introduced by r139866
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Pablo Flouret
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-16 15:32 PST by Pablo Flouret
Modified: 2013-01-16 17:37 PST (History)
4 users (show)

See Also:

Attachments
Patch (7.75 KB, patch)
2013-01-16 15:49 PST, Pablo Flouret 		no flags Details | Formatted Diff | Diff
Patch (7.57 KB, patch)
2013-01-16 16:50 PST, Pablo Flouret 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pablo Flouret 2013-01-16 15:32:29 PST 
warning: no rule to process file '$(PROJECT_DIR)/css/CSSSupportsRule.h' of type sourcecode.c.h for architecture x86_64
warning: no rule to process file '$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSCSSSupportsRule.h' of type sourcecode.c.h for architecture x86_64
ld: warning: ignoring undefined symbol .objc_class_name_DOMCSSSupportsRule from -exported_symbols_list

{JS,}CSSSupportsRule.h somehow ended up marked as sources in the XCode project. And explicitely declaring the DOMCSSSupportsRule symbol is apparently not needed...
Comment 1 Pablo Flouret 2013-01-16 15:49:21 PST 
Created attachment 183049 [details]
Patch
Comment 2 Benjamin Poulain 2013-01-16 16:10:42 PST 
Comment on attachment 183049 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=183049&action=review

> Source/WebCore/WebCore.exp.in:1580
>  .objc_class_name_DOMCSSStyleSheet
> -.objc_class_name_DOMCSSSupportsRule
>  .objc_class_name_DOMCSSUnknownRule
>  .objc_class_name_DOMCSSValue

This is incorrect. I landed something for this: http://trac.webkit.org/changeset/139933

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:26129
> +				FC54D05716A7673100575E4D /* CSSSupportsRule.h in Headers */,
> +				FC54D05816A7676E00575E4D /* JSCSSSupportsRule.h in Headers */,

This build section should be sorted alphabetically.
Comment 3 Pablo Flouret 2013-01-16 16:50:55 PST 
Created attachment 183063 [details]
Patch
Comment 4 Benjamin Poulain 2013-01-16 16:55:28 PST 
Comment on attachment 183063 [details]
Patch

I am no expert at Xcode project files, but that looks reasonable.

Thanks for fixing the warnings.
Comment 5 WebKit Review Bot 2013-01-16 17:37:35 PST 
Comment on attachment 183063 [details]
Patch

Clearing flags on attachment: 183063

Committed r139941: <http://trac.webkit.org/changeset/139941>
Comment 6 WebKit Review Bot 2013-01-16 17:37:39 PST 
All reviewed patches have been landed.  Closing bug.