Bug 104796 - Web Inspector: Native Memory Instrumentation: remove fake root MemoryObjectInfo.
Summary: Web Inspector: Native Memory Instrumentation: remove fake root MemoryObjectInfo.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks: 104660
  Show dependency treegraph
 
Reported: 2012-12-12 04:26 PST by Ilya Tikhonovsky
Modified: 2012-12-12 08:07 PST (History)
11 users (show)

See Also:


Attachments
Patch (17.23 KB, patch)
2012-12-12 04:30 PST, Ilya Tikhonovsky
no flags Details | Formatted Diff | Diff
Patch (22.67 KB, patch)
2012-12-12 07:24 PST, Ilya Tikhonovsky
no flags Details | Formatted Diff | Diff
with fixed def file (22.97 KB, patch)
2012-12-12 07:34 PST, Ilya Tikhonovsky
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2012-12-12 04:26:20 PST
It was not a good idea to introduce a fake root MemoryObjectInfo.
It makes a problem when we visit an object without its own MemoryObjectType.

Example: RenderBox has a global pointer to a hash map.
HashMap doesn't have its own object type because it is a generic container.
It will inherit object type from the fake root memory object info.
The same could happen for another container in another class with other MemoryObjectType.

This fact forces me to create custom process method for root objects
because they need to have their own MemoryObjectInfo with customisable memory object type.

patch to follow.
Comment 1 Ilya Tikhonovsky 2012-12-12 04:30:59 PST
Created attachment 179023 [details]
Patch
Comment 2 Ilya Tikhonovsky 2012-12-12 07:24:49 PST
Created attachment 179034 [details]
Patch
Comment 3 Ilya Tikhonovsky 2012-12-12 07:34:30 PST
Created attachment 179039 [details]
with fixed def file
Comment 4 WebKit Review Bot 2012-12-12 07:36:46 PST
Attachment 179039 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/ChangeLog:20:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Ilya Tikhonovsky 2012-12-12 08:07:44 PST
Committed r137468: <http://trac.webkit.org/changeset/137468>