Bug 104660 - Web Inspector: instrument static parts of RenderBlock and RenderBox
Summary: Web Inspector: instrument static parts of RenderBlock and RenderBox
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on: 104796
Blocks:
  Show dependency treegraph
 
Reported: 2012-12-11 04:41 PST by Ilya Tikhonovsky
Modified: 2012-12-12 08:53 PST (History)
17 users (show)

See Also:


Attachments
Patch (27.12 KB, patch)
2012-12-11 05:51 PST, Ilya Tikhonovsky
no flags Details | Formatted Diff | Diff
with fix for Windows (28.58 KB, patch)
2012-12-11 08:42 PST, Ilya Tikhonovsky
no flags Details | Formatted Diff | Diff
will not compile without wkbug 104796 (8.41 KB, patch)
2012-12-12 04:44 PST, Ilya Tikhonovsky
no flags Details | Formatted Diff | Diff
rebaseline (8.48 KB, patch)
2012-12-12 08:11 PST, Ilya Tikhonovsky
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2012-12-11 04:41:01 PST
EOM
Comment 1 Ilya Tikhonovsky 2012-12-11 05:51:01 PST
Created attachment 178785 [details]
Patch
Comment 2 Build Bot 2012-12-11 06:15:12 PST
Comment on attachment 178785 [details]
Patch

Attachment 178785 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/15276199
Comment 3 Ilya Tikhonovsky 2012-12-11 08:42:17 PST
Created attachment 178814 [details]
with fix for Windows
Comment 4 Yury Semikhatsky 2012-12-12 00:57:45 PST
Comment on attachment 178814 [details]
with fix for Windows

Let's split this patch into SequenceMemoryInstrumentationTraits changes, addRootObject and actual instrumentation of the static members?
Comment 5 Ilya Tikhonovsky 2012-12-12 04:44:04 PST
Created attachment 179024 [details]
will not compile without wkbug 104796
Comment 6 Early Warning System Bot 2012-12-12 04:54:43 PST
Comment on attachment 179024 [details]
will not compile without wkbug 104796

Attachment 179024 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/15285275
Comment 7 Early Warning System Bot 2012-12-12 04:57:27 PST
Comment on attachment 179024 [details]
will not compile without wkbug 104796

Attachment 179024 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/15272744
Comment 8 Build Bot 2012-12-12 05:15:50 PST
Comment on attachment 179024 [details]
will not compile without wkbug 104796

Attachment 179024 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/15285280
Comment 9 WebKit Review Bot 2012-12-12 05:32:16 PST
Comment on attachment 179024 [details]
will not compile without wkbug 104796

Attachment 179024 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15275654
Comment 10 EFL EWS Bot 2012-12-12 05:42:30 PST
Comment on attachment 179024 [details]
will not compile without wkbug 104796

Attachment 179024 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/15276660
Comment 11 Peter Beverloo (cr-android ews) 2012-12-12 06:01:52 PST
Comment on attachment 179024 [details]
will not compile without wkbug 104796

Attachment 179024 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/15296101
Comment 12 Peter Beverloo (cr-android ews) 2012-12-12 07:03:44 PST
Comment on attachment 179024 [details]
will not compile without wkbug 104796

Attachment 179024 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/15260859
Comment 13 Build Bot 2012-12-12 07:51:36 PST
Comment on attachment 179024 [details]
will not compile without wkbug 104796

Attachment 179024 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15281518
Comment 14 Ilya Tikhonovsky 2012-12-12 08:11:13 PST
Created attachment 179048 [details]
rebaseline
Comment 15 Yury Semikhatsky 2012-12-12 08:46:50 PST
Comment on attachment 179048 [details]
rebaseline

View in context: https://bugs.webkit.org/attachment.cgi?id=179048&action=review

> Source/WebCore/dom/WebCoreMemoryInstrumentation.h:87
> +    static void reportMemoryUsage(WTF::MemoryInstrumentation*);

reportStaticMembersMemoryUsage would be more accurate name
Comment 16 Ilya Tikhonovsky 2012-12-12 08:53:50 PST
Committed r137472: <http://trac.webkit.org/changeset/137472>