Bug 104748 – webdatabase: Split code between the DatabaseManager and DatabaseServer

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Mark Lam]

Split the DatabaseManager into a front-end and a back-end DatabaseServer.

[Mark Lam]

Created attachment 179186 [details]
work in progress 1.

[Early Warning System Bot]

Comment on attachment 179186 [details]
work in progress 1.

Attachment 179186 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/15310107

[Mark Lam]

Created attachment 179188 [details]
work in progress again: fixed Qt issue.

[EFL EWS Bot]

Comment on attachment 179188 [details]
work in progress again: fixed Qt issue.

Attachment 179188 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/15322103

[Mark Lam]

Created attachment 179207 [details]
wip1: attempt at fixing the elf build failure.

[Mark Lam]

Created attachment 179429 [details]
work in progress 2: DatabaseTracker is now only accessed from DBBackend::Server + moving more stuff to DatabaseManager and the server.

[Peter Beverloo (cr-android ews)]

Comment on attachment 179429 [details]
work in progress 2: DatabaseTracker is now only accessed from DBBackend::Server + moving more stuff to DatabaseManager and the server.

Attachment 179429 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/15311587

[WebKit Review Bot]

Comment on attachment 179429 [details]
work in progress 2: DatabaseTracker is now only accessed from DBBackend::Server + moving more stuff to DatabaseManager and the server.

Attachment 179429 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15317579

[Mark Lam]

Created attachment 179437 [details]
wip2: + fixed chromium breakage. test ews again.

[WebKit Review Bot]

Comment on attachment 179437 [details]
wip2: + fixed chromium breakage. test ews again.

Attachment 179437 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15316634

[Mark Lam]

Created attachment 179441 [details]
wip2: + fixed 2nd chromium breakage. test ews again.

[Mark Lam]

Created attachment 179444 [details]
wp2: svn up'ed.

[Mark Lam]

Created attachment 179842 [details]
The final (hopefully) patch.

This patch performs some initial refactoring to split Database functionality between the front-end DatabaseManager and the backend DBBackend::Server.  With this patch,
1. All DatabaseTracker accesses now go thru the DBBackend::Server.
2. Database::openDatabase() and DatabaseSync::openDatabaseSync() factory methods have been moved into the DatabaseManager.
3. AbstractDatabase::isAvailable() and AbstractDatabase::setIsAvailable() have been moved into the DatabaseManager.
4. Added DatabaseBasicTypes.h to hold common basic / primitive types that the webdatabase module uses.

This refactoring does not change how the code flows / works yet.  It only moves and renames things.

[Early Warning System Bot]

Comment on attachment 179842 [details]
The final (hopefully) patch.

Attachment 179842 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/15374929

[Early Warning System Bot]

Comment on attachment 179842 [details]
The final (hopefully) patch.

Attachment 179842 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/15374928

[Mark Lam]

Created attachment 179855 [details]
The fixed patch: added needed #include's.

[Mark Lam]

Created attachment 179863 [details]
The fixed patch minus some development changes in the Xcode project not ready for a commit yet.

[Brady Eidson]

Comment on attachment 179863 [details]
The fixed patch minus some development changes in the Xcode project not ready for a commit yet.

Seeing the pattern that this is largely a refactor that is shuffling code around, I didn't look at certain pieces of it in depth.  Seems fine as long as layouttests pass, etc etc.

[Mark Lam]

(In reply to comment #18)
> (From update of attachment 179863 [details])
> Seeing the pattern that this is largely a refactor that is shuffling code around, I didn't look at certain pieces of it in depth.  Seems fine as long as layouttests pass, etc etc.

Yes, this phase of the refactor is largely just shuffling code.

The patch has been landed in r138085: <http://trac.webkit.org/changeset/138085>.

[Adam Klein]

(In reply to comment #19)
> (In reply to comment #18)
> > (From update of attachment 179863 [details] [details])
> > Seeing the pattern that this is largely a refactor that is shuffling code around, I didn't look at certain pieces of it in depth.  Seems fine as long as layouttests pass, etc etc.
> 
> Yes, this phase of the refactor is largely just shuffling code.
> 
> The patch has been landed in r138085: <http://trac.webkit.org/changeset/138085>.

r138085 seems very broken. In particular, at least one file is completely doubled (i.e., contains two copies of the same thing), resulting in compile failures:

http://trac.webkit.org/browser/trunk/Source/WebCore/Modules/webdatabase/DBBackendServer.cpp?rev=138085

[Mark Lam]

(In reply to comment #20)
> (In reply to comment #19)
> > (In reply to comment #18)
> > > (From update of attachment 179863 [details] [details] [details])
> > > Seeing the pattern that this is largely a refactor that is shuffling code around, I didn't look at certain pieces of it in depth.  Seems fine as long as layouttests pass, etc etc.
> > 
> > Yes, this phase of the refactor is largely just shuffling code.
> > 
> > The patch has been landed in r138085: <http://trac.webkit.org/changeset/138085>.
> 
> r138085 seems very broken. In particular, at least one file is completely doubled (i.e., contains two copies of the same thing), resulting in compile failures:
> 
> http://trac.webkit.org/browser/trunk/Source/WebCore/Modules/webdatabase/DBBackendServer.cpp?rev=138085

My apologies.  It looks like a merge issue in my local files.  I'm fixing it now.

[Mark Lam]

(In reply to comment #21)
> My apologies.  It looks like a merge issue in my local files.  I'm fixing it now.

Fixed and landed in r138088: <http://trac.webkit.org/changeset/138088>.