Bug 104741 – webdatabase: Encapsulate externally used DB APIs in DatabaseManager

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Mark Lam]

Introduce a DatabaseManager module to encapsulate APIs that are called by code outside the webdatabase module.

[Mark Lam]

Created attachment 178956 [details]
The patch.

Let's see how the EWS bots like it.

[WebKit Review Bot]

Comment on attachment 178956 [details]
The patch.

Attachment 178956 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15277436

[Peter Beverloo (cr-android ews)]

Comment on attachment 178956 [details]
The patch.

Attachment 178956 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/15272574

[Build Bot]

Comment on attachment 178956 [details]
The patch.

Attachment 178956 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/15284279

[EFL EWS Bot]

Comment on attachment 178956 [details]
The patch.

Attachment 178956 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/15281352

[Mark Lam]

Created attachment 178981 [details]
Fixed a few issues, and let's retry with the EWS bots.

[Mark Lam]

Created attachment 178984 [details]
svn up'ed to get the patch to apply properly.

[WebKit Review Bot]

Comment on attachment 178984 [details]
svn up'ed to get the patch to apply properly.

Attachment 178984 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15300001

[Peter Beverloo (cr-android ews)]

Comment on attachment 178984 [details]
svn up'ed to get the patch to apply properly.

Attachment 178984 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/15276572

[Mark Lam]

Created attachment 178988 [details]
Fix bug in chromium port.

[EFL EWS Bot]

Comment on attachment 178988 [details]
Fix bug in chromium port.

Attachment 178988 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/15272699

[Mark Lam]

Created attachment 179035 [details]
5th time's the charm: svn up, updated ChangeLog comments.

Let's retry the EWS bots after an svn up to see if the gtk and elf issues are resolved.  The failures from the last patch do not seem to be related to the patch.

[EFL EWS Bot]

Comment on attachment 179035 [details]
5th time's the charm: svn up, updated ChangeLog comments.

Attachment 179035 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/15286339

[Mark Lam]

Created attachment 179070 [details]
Added a #include to make the elf port happy.  Also updated ChangeLog dates and fixed a typo.

[Mark Lam]

Comment on attachment 179070 [details]
Added a #include to make the elf port happy.  Also updated ChangeLog dates and fixed a typo.

Ready for a review.  The elf ews will take a while to process.  It was previously complaining about CString only being forward declared.  The added #include <wtf/text/CString.h> should take care of the issue.

[Mark Lam]

Created attachment 179105 [details]
svn up again to get the patch to apply.

[Mark Lam]

Landed in r137520: <http://trac.webkit.org/changeset/137520>.

[Mark Lam]

aklein reported that r137520 is causing a build breakage in chromium:

Undefined symbols:
  "__ZN7WebCore15DatabaseTracker17initializeTrackerERKN3WTF6StringE", referenced from:
      __ZN7WebCore15DatabaseManager10initializeERKN3WTF6StringE in libwebcore_remaining.a(DatabaseManager.o)
ld: symbol(s) not found

The issue is because chromium does not use the same DatabaseTracker class, and hence does not have nor need the call to DatabaseTracker::initializeTracker() function.

The fix is landed in r137530: <http://trac.webkit.org/changeset/137530>.

[Michael Nordman]

Comment on attachment 178988 [details]
Fix bug in chromium port.

View in context: https://bugs.webkit.org/attachment.cgi?id=178988&action=review

> Source/WebCore/WebCore.gypi:990
> +            'Modules/webdatabase/DatabaseManager.cpp',

Please add .h files to webcore.gyi as well when adding new files to webcore.

We generally add all files to this gypi, including .cpp files that we actually exclude from our build further downstream (in WebCore.gpy/WebCore.gyp).