Bug 104725 – Crash in EventHandler::selectCursor() on Mac bots running fast/events/mouse-cursor-image-set.html

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Beth Dakin]

https://bugs.webkit.org/show_bug.cgi?id=99493 enabled image-set for the CSS cursor property. Most of the change is guarded behind #if ENABLE(MOUSE_CURSOR_SCALE).

On the Mac port, we have image-set enabled, so we still parse the image-set in the CSSParser for cursors. But MOUSE_CURSOR_SCALE is not yet enabled, see https://bugs.webkit.org/show_bug.cgi?id=102579

Because we parse the image-set anyway, we see this crash:

 ASSERT(scale == 1);
Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   com.apple.WebCore             	0x000000010faa8eb6 WebCore::EventHandler::selectCursor(WebCore::MouseEventWithHitTestResults const&, WebCore::Scrollbar*) + 1526 (EventHandler.cpp:1481)
1   com.apple.WebCore             	0x000000010faab46c WebCore::EventHandler::handleMouseMoveEvent(WebCore::PlatformMouseEvent const&, WebCore::HitTestResult*, bool) + 1772 (EventHandler.cpp:1912)
2   com.apple.WebCore             	0x000000010faaabd6 WebCore::EventHandler::mouseMoved(WebCore::PlatformMouseEvent const&) + 134 (EventHandler.cpp:1795)
3   com.apple.WebKit2             	0x000000010d37e44c WebKit::handleMouseEvent(WebKit::WebMouseEvent const&, WebKit::WebPage*, bool) + 396 (WebPage.cpp:1526)
4   com.apple.WebKit2             	0x000000010d37e5aa WebKit::WebPage::mouseEventSyncForTesting(WebKit::WebMouseEvent const&, bool&) + 234 (WebPage.cpp:1576)
etc.

I think that the right way to fix this is to avoid parsing the image-set for cursors until it's fully supported on Mac.

[Beth Dakin]

Created attachment 178889 [details]
Patch

[Beth Dakin]

Thanks, Tim! 

http://trac.webkit.org/changeset/137367

[Rick Byers]

Shoot, sorry about that!  Doing exactly what you've done was always my intention (and how I was thinking I had written it) - sorry I missed that.

[Beth Dakin]

(In reply to comment #3)
> Shoot, sorry about that!  Doing exactly what you've done was always my intention (and how I was thinking I had written it) - sorry I missed that.

No worries! It happens.