Bug 102579 - [mac] Enable scaled cursors
Summary: [mac] Enable scaled cursors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Beth Dakin
URL:
Keywords: InRadar
Depends on: 99493
Blocks:
  Show dependency treegraph
 
Reported: 2012-11-16 20:53 PST by Rick Byers
Modified: 2012-12-18 14:27 PST (History)
6 users (show)

See Also:


Attachments
Patch (7.24 KB, patch)
2012-12-18 14:15 PST, Beth Dakin
dino: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rick Byers 2012-11-16 20:53:34 PST
Set ENABLE(MOUSE_CURSOR_SCALE) on Mac port so that high-dpi custom mouse cursors can be used

Beth, I have no experience with Mac development (and I'm not sure when exactly you'd want to enable this feature), can I give this piece to you?  Once bug 99493 lands, the remaining work for Mac should be trivial - just set MOUSE_CURSOR_SCALE and update WebCore/platform/mac/CursorMac.mm to use the imageScaleFactor value when setting a custom cursor image.
Comment 1 Beth Dakin 2012-11-26 11:34:57 PST
(In reply to comment #0)
> Set ENABLE(MOUSE_CURSOR_SCALE) on Mac port so that high-dpi custom mouse cursors can be used
> 
> Beth, I have no experience with Mac development (and I'm not sure when exactly you'd want to enable this feature), can I give this piece to you?  Once bug 99493 lands, the remaining work for Mac should be trivial - just set MOUSE_CURSOR_SCALE and update WebCore/platform/mac/CursorMac.mm to use the imageScaleFactor value when setting a custom cursor image.

Sure, thank you.
Comment 2 Radar WebKit Bug Importer 2012-12-06 19:08:54 PST
<rdar://problem/12832295>
Comment 3 Beth Dakin 2012-12-18 14:15:08 PST
Created attachment 180023 [details]
Patch
Comment 4 Dean Jackson 2012-12-18 14:19:13 PST
Comment on attachment 180023 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180023&action=review

> Source/WebCore/ChangeLog:10
> +        defined, and we need to initialize m_imageScaleFactor in the Cursor constructors.
> +        * Configurations/FeatureDefines.xcconfig:

Nit: blank line between here.
Comment 5 Beth Dakin 2012-12-18 14:27:34 PST
Thanks, Dean! http://trac.webkit.org/changeset/138069