Bug 102579 – [mac] Enable scaled cursors

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Rick Byers]

Set ENABLE(MOUSE_CURSOR_SCALE) on Mac port so that high-dpi custom mouse cursors can be used

Beth, I have no experience with Mac development (and I'm not sure when exactly you'd want to enable this feature), can I give this piece to you?  Once bug 99493 lands, the remaining work for Mac should be trivial - just set MOUSE_CURSOR_SCALE and update WebCore/platform/mac/CursorMac.mm to use the imageScaleFactor value when setting a custom cursor image.

[Beth Dakin]

(In reply to comment #0)
> Set ENABLE(MOUSE_CURSOR_SCALE) on Mac port so that high-dpi custom mouse cursors can be used
> 
> Beth, I have no experience with Mac development (and I'm not sure when exactly you'd want to enable this feature), can I give this piece to you?  Once bug 99493 lands, the remaining work for Mac should be trivial - just set MOUSE_CURSOR_SCALE and update WebCore/platform/mac/CursorMac.mm to use the imageScaleFactor value when setting a custom cursor image.

Sure, thank you.

[Radar WebKit Bug Importer]

<rdar://problem/12832295>

[Beth Dakin]

Created attachment 180023 [details]
Patch

[Dean Jackson]

Comment on attachment 180023 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180023&action=review

> Source/WebCore/ChangeLog:10
> +        defined, and we need to initialize m_imageScaleFactor in the Cursor constructors.
> +        * Configurations/FeatureDefines.xcconfig:

Nit: blank line between here.

[Beth Dakin]

Thanks, Dean! http://trac.webkit.org/changeset/138069