RESOLVED FIXED104720
Make Video Track compile on Windows in debug mode. 
https://bugs.webkit.org/show_bug.cgi?id=104720
Summary Make Video Track compile on Windows in debug mode.
Roger Fong
Reported 2012-12-11 14:42:46 PST
There were two problems after enabling Video Track on Windows with compiling in debug mode. 1. urlForLogging method was defined in both HTMLMediaElement.cpp and HTMLTrackElement.cpp. On Windows all the HTMLElements sources are included in an AllInOne source file, so the definitions conflicted. Fixed by renaming the definition in each source file. 2. Logging.h was included in header PODRedBlackTree.h. Including Logging.h so causes the LOG_CHANNEL_PREFIX incorrectly defined as "Log" instead of "WebKitLog" in WebView.cpp.
Attachments
patch (6.53 KB, patch)
2012-12-11 15:37 PST, Roger Fong 		ap: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2012-12-11 15:04:45 PST
> 2. Logging.h was included in header PODRedBlackTree.h. Including Logging.h so causes the LOG_CHANNEL_PREFIX incorrectly defined as "Log" instead of "WebKitLog" in WebView.cpp. I'm fixing that in bug 104718.
Roger Fong
Comment 2 2012-12-11 15:37:40 PST
Created attachment 178896 [details] patch Just fixing #1 then.
Roger Fong
Comment 3 2012-12-11 16:20:48 PST
committed r137378
Note You need to log in before you can comment on or make changes to this bug.