Bug 104704 - [Chromium] Remove all references to sharedWorkerRepository()
Summary: [Chromium] Remove all references to sharedWorkerRepository()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Pilgrim (Google)
URL:
Keywords:
: 85768 (view as bug list)
Depends on: 104838 105505
Blocks: 82948
  Show dependency treegraph
 
Reported: 2012-12-11 12:53 PST by Mark Pilgrim (Google)
Modified: 2013-01-03 14:27 PST (History)
8 users (show)

See Also:


Attachments
Patch (3.11 KB, patch)
2012-12-11 12:54 PST, Mark Pilgrim (Google)
no flags Details | Formatted Diff | Diff
Patch (3.09 KB, patch)
2012-12-19 07:45 PST, Mark Pilgrim (Google)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Pilgrim (Google) 2012-12-11 12:53:50 PST
[Chromium] Remove all references to sharedWorkerRepository()
Comment 1 Mark Pilgrim (Google) 2012-12-11 12:54:29 PST
Created attachment 178855 [details]
Patch
Comment 2 Mark Pilgrim (Google) 2012-12-11 12:54:47 PST
*** Bug 85768 has been marked as a duplicate of this bug. ***
Comment 3 WebKit Review Bot 2012-12-11 12:57:44 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 4 WebKit Review Bot 2012-12-12 11:33:13 PST
Comment on attachment 178855 [details]
Patch

Clearing flags on attachment: 178855

Committed r137490: <http://trac.webkit.org/changeset/137490>
Comment 5 WebKit Review Bot 2012-12-12 11:33:16 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Review Bot 2012-12-12 13:31:18 PST
Re-opened since this is blocked by bug 104838
Comment 7 Mark Pilgrim (Google) 2012-12-19 07:45:27 PST
Created attachment 180163 [details]
Patch
Comment 8 Mark Pilgrim (Google) 2012-12-19 07:46:19 PST
Comment on attachment 180163 [details]
Patch

No longer breaks downstream build because https://codereview.chromium.org/11576028/ has landed.
Comment 9 WebKit Review Bot 2012-12-19 21:24:14 PST
Comment on attachment 180163 [details]
Patch

Clearing flags on attachment: 180163

Committed r138215: <http://trac.webkit.org/changeset/138215>
Comment 10 WebKit Review Bot 2012-12-19 21:24:18 PST
All reviewed patches have been landed.  Closing bug.
Comment 11 WebKit Review Bot 2012-12-20 01:04:58 PST
Re-opened since this is blocked by bug 105505
Comment 12 Yury Semikhatsky 2012-12-20 01:06:25 PST
(In reply to comment #9)
> (From update of attachment 180163 [details])
> Clearing flags on attachment: 180163
> 
> Committed r138215: <http://trac.webkit.org/changeset/138215>

The change breaks Chromium compilation: 

../../content/renderer/renderer_webkitplatformsupport_impl.h:71:46: error: 'sharedWorkerRepository' marked 'override' but does not override any member functions
  virtual WebKit::WebSharedWorkerRepository* sharedWorkerRepository() OVERRIDE;
                                             ^
1 error generated.

You should have removed Chromium override before landing this patch.
Comment 13 Mark Pilgrim (Google) 2013-01-03 13:52:59 PST
Comment on attachment 180163 [details]
Patch

Should no longer break Chromium compilation now that https://codereview.chromium.org/11744005/ has landed downstream.

Patch still applies cleanly to ToT.
Comment 14 WebKit Review Bot 2013-01-03 14:27:20 PST
Comment on attachment 180163 [details]
Patch

Clearing flags on attachment: 180163

Committed r138742: <http://trac.webkit.org/changeset/138742>
Comment 15 WebKit Review Bot 2013-01-03 14:27:24 PST
All reviewed patches have been landed.  Closing bug.