Bug 105505 - REGRESSION(r138215): it broke downstream compilation with clang (Requested by loislo on #webkit).
Summary: REGRESSION(r138215): it broke downstream compilation with clang (Requested by...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: WebKit Review Bot
URL:
Keywords:
Depends on:
Blocks: 104704
  Show dependency treegraph
 
Reported: 2012-12-20 01:04 PST by WebKit Review Bot
Modified: 2012-12-20 01:09 PST (History)
2 users (show)

See Also:


Attachments
ROLLOUT of r138215 (3.13 KB, patch)
2012-12-20 01:05 PST, WebKit Review Bot
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2012-12-20 01:04:52 PST
http://trac.webkit.org/changeset/138215 broke the build:
it broke downstream compilation with clang (Requested by loislo on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear
Comment 1 WebKit Review Bot 2012-12-20 01:05:36 PST
Created attachment 180292 [details]
ROLLOUT of r138215

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Ilya Tikhonovsky 2012-12-20 01:07:17 PST
please fix downstream part first.

../../content/renderer/renderer_webkitplatformsupport_impl.h:71:46: error: 'sharedWorkerRepository' marked 'override' but does not override any member functions
  virtual WebKit::WebSharedWorkerRepository* sharedWorkerRepository() OVERRIDE;
                                             ^
Comment 3 Ilya Tikhonovsky 2012-12-20 01:09:01 PST
Comment on attachment 180292 [details]
ROLLOUT of r138215

Clearing flags on attachment: 180292

Committed r138233: <http://trac.webkit.org/changeset/138233>
Comment 4 Ilya Tikhonovsky 2012-12-20 01:09:07 PST
All reviewed patches have been landed.  Closing bug.