Bug 104676 - [GTK] Force single header includes in GObject DOM bindings
Summary: [GTK] Force single header includes in GObject DOM bindings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 104663
Blocks:
  Show dependency tree / graph
 
Reported: 2012-12-11 07:28 PST by Carlos Garcia Campos
Modified: 2013-02-18 06:47 PST (History)
2 users (show)

See Also:

Attachments
Patch (11.72 KB, patch)
2012-12-11 07:30 PST, Carlos Garcia Campos 		xan.lopez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2012-12-11 07:28:15 PST 
Only <webkitdom/webkitdom.h> should be allowed from apps.
Comment 1 Martin Robinson 2012-12-11 07:29:49 PST 
Won't this break existing code?
Comment 2 Carlos Garcia Campos 2012-12-11 07:30:36 PST 
Created attachment 178801 [details]
Patch

This patch applies on top of patch attached to bug #104663
Comment 3 Carlos Garcia Campos 2012-12-11 07:31:54 PST 
Apps are already supposed to only include webkit/webkitdom.h. That's still allowed
Comment 4 Xan Lopez 2013-02-11 11:17:36 PST 
(In reply to comment #3)
> Apps are already supposed to only include webkit/webkitdom.h. That's still allowed

I think this patch is right, but what apps are we talking about exactly? WK1 apps should never include anything other than the single header. I'd assume the same applies for WK2 apps save for the WebProcess plugin stuff?
Comment 5 Xan Lopez 2013-02-11 11:18:17 PST 
Comment on attachment 178801 [details]
Patch

Regardless of the other comments including single DOM headers was never allowed, even if this was missing.
Comment 6 Carlos Garcia Campos 2013-02-18 06:47:06 PST 
Committed r143212: <http://trac.webkit.org/changeset/143212>