Bug 104663 - [GTK] Install GObject DOM bindings headers in its own directory
: [GTK] Install GObject DOM bindings headers in its own directory
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: WebKit Gtk
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Nobody
:
Depends on:
Blocks: 104676
  Show dependency treegraph
 
Reported: 2012-12-11 05:33 PST by Carlos Garcia Campos
Modified: 2012-12-11 09:59 PST (History)
8 users (show)

See Also:


Attachments
Patch (86.56 KB, patch)
2012-12-11 05:40 PST, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff
Updated patch to apply on current git master (86.12 KB, patch)
2012-12-11 05:54 PST, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff
Try to fix the build (86.21 KB, patch)
2012-12-11 08:49 PST, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2012-12-11 05:33:53 PST
Instead of sharing the webkit1 gtk api directory, move the headers to <webkitdom/webkitdom.h>.
Comment 1 Carlos Garcia Campos 2012-12-11 05:40:13 PST
Created attachment 178782 [details]
Patch
Comment 2 Carlos Garcia Campos 2012-12-11 05:54:41 PST
Created attachment 178786 [details]
Updated patch to apply on current git master
Comment 3 Carlos Garcia Campos 2012-12-11 06:59:12 PST
I think EWS failed because it requires a clean build, I wonder why it didn't generate the bindings again, since the patch modifies the generator script, though.
Comment 4 WebKit Review Bot 2012-12-11 07:02:10 PST
Attachment 178786 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'GNUmakefile.am', u'Source/We..." exit_code: 1
Source/WebKit/gtk/webkit/webkitdom.h:20:  #ifndef header guard has wrong style, please use: webkitdom_h  [build/header_guard] [5]
Total errors found: 1 in 48 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Carlos Garcia Campos 2012-12-11 08:49:14 PST
Created attachment 178816 [details]
Try to fix the build

Build break was indeed my fault, I forgot to add new variable for built sources to BUILT_SOURCES. Thanks kov!
Comment 6 WebKit Review Bot 2012-12-11 08:53:25 PST
Attachment 178816 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'GNUmakefile.am', u'Source/We..." exit_code: 1
Source/WebKit/gtk/webkit/webkitdom.h:20:  #ifndef header guard has wrong style, please use: webkitdom_h  [build/header_guard] [5]
Total errors found: 1 in 48 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 WebKit Review Bot 2012-12-11 09:59:04 PST
Comment on attachment 178816 [details]
Try to fix the build

Clearing flags on attachment: 178816

Committed r137329: <http://trac.webkit.org/changeset/137329>
Comment 8 WebKit Review Bot 2012-12-11 09:59:08 PST
All reviewed patches have been landed.  Closing bug.