Bug 104457 - Remove code duplicates from MacroAssemblerARM
Summary: Remove code duplicates from MacroAssemblerARM
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other All
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks: 108645
  Show dependency tree / graph
 
Reported: 2012-12-08 14:22 PST by Patrick R. Gansterer
Modified: 2013-04-10 13:32 PDT (History)
9 users (show)

See Also:

Attachments
Patch (4.28 KB, patch)
2012-12-08 14:30 PST, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
Patch (4.32 KB, patch)
2013-02-01 14:56 PST, Patrick R. Gansterer 		webkit.review.bot: review-
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2012-12-08 14:22:45 PST 
Remove code duplicates from MacroAssemblerARM
Comment 1 Patrick R. Gansterer 2012-12-08 14:30:34 PST 
Created attachment 178381 [details]
Patch
Comment 2 Darin Adler 2012-12-08 14:32:42 PST 
Comment on attachment 178381 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=178381&action=review

> Source/JavaScriptCore/assembler/MacroAssemblerARM.h:491
> -        m_assembler.ldrUniqueImmediate(ARMRegisters::S0, reinterpret_cast<ARMWord>(address));
> -        m_assembler.moveImm(imm.m_value, ARMRegisters::S1);
> -        m_assembler.dtrUp(ARMAssembler::StoreUint32, ARMRegisters::S1, ARMRegisters::S0, 0);
> +        move(imm, ARMRegisters::S1);
> +        store32(ARMRegisters::S1, address);

This doesn’t generate the same code. The moveImm will now come first, before the ldrUniqueImmediate. Is that OK? Is one or the other faster?
Comment 3 Patrick R. Gansterer 2013-02-01 14:56:31 PST 
Created attachment 186152 [details]
Patch
Comment 4 Csaba Osztrogonác 2013-02-15 03:28:42 PST 
Could you check this bug?
Comment 5 WebKit Review Bot 2013-02-15 10:58:29 PST 
Comment on attachment 186152 [details]
Patch

Rejecting attachment 186152 [details] from review queue.

oliver@apple.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.
Comment 6 WebKit Review Bot 2013-02-15 11:13:28 PST 
Comment on attachment 186152 [details]
Patch

Rejecting attachment 186152 [details] from commit-queue.

oliver@apple.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 7 Patrick R. Gansterer 2013-04-10 13:32:16 PDT 
Committed r148134: <http://trac.webkit.org/changeset/148134>