Bug 104431 – [EFL] Change the minimum required EFL version to 1.6

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Laszlo Gombos]

Revision http://trac.webkit.org/changeset/130887 changed the minimum required EFL version to 1.7. I have found that EFL port of WebKit builds on public releases of EFL labeled as 1.6+ and found no evidence that 1.7 is indeed required.

Note that the "reference" EFL version that is used by most developers and in the buildbot as it is specified in the jhbuild configuration (http://trac.webkit.org/browser/trunk/Tools/efl/jhbuild.modules) does not need to be downgraded and should continue to advance inversion as it was rightly pointed out by Raphael as well in another bug (https://bugs.webkit.org/show_bug.cgi?id=97523#c4).

[Laszlo Gombos]

Created attachment 178333 [details]
proposed patch

This is technically a build fix for my environment.

[Kenneth Rohde Christiansen]

Comment on attachment 178333 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=178333&action=review

> ChangeLog:11
> +
> +        Change the minimum required EFL version to 1.6 from 1.7.
> +        The elementary EFL package is only required to build MiniBrowser,
> +        so I moved the required only to the Minibrowser CMake file.
> +

I don't see the point in this. Why promote older versions for no reason? The packages might not be required, but they might contain bugfixes and other api that we might want to use without having to bump version back

[Kenneth Rohde Christiansen]

I rather want us to push the most recent version tested to work

[Laszlo Gombos]

Created attachment 178568 [details]
update the patch with the justification

> Why promote older versions for no reason?

The reason is to support building for Tizen (trunk).

> I rather want us to push the most recent version tested to work.

I agree with the desire to update Tizen to use EFL v1.7+, but until the update is not in place I think it is a good compromise to enable (not necessary promote) building using EFL v1.6+.

I updated the patch to include the reasoning and a warning message if EFL v1.6 is used.

[Kenneth Rohde Christiansen]

Comment on attachment 178568 [details]
update the patch with the justification

View in context: https://bugs.webkit.org/attachment.cgi?id=178568&action=review

> ChangeLog:10
> +
> +        Change the minimum required EFL version to 1.6 from 1.7.
> +        The elementary EFL package is only required to build MiniBrowser,
> +        so I moved the required only to the Minibrowser CMake file.

Where is this justification?

[Laszlo Gombos]

Created attachment 178575 [details]
right patch this time

[WebKit Review Bot]

Comment on attachment 178575 [details]
right patch this time

Clearing flags on attachment: 178575

Committed r137203: <http://trac.webkit.org/changeset/137203>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.