WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 97523
[EFL] Update minimal required versions
https://bugs.webkit.org/show_bug.cgi?id=97523
Summary
[EFL] Update minimal required versions
Laszlo Gombos
Reported
2012-09-24 21:58:17 PDT
It seems that there are 2 place in the source tree where the minimal required version for the dependencies are stored; 1./ OptionsEfl.cmake and 2./ jhbuild.modules. I propose that we should try to keep the 2 aligned or alternatively we should only enforce the version check in one place but not in the other place.
Attachments
use the same versions in both places
(2.17 KB, patch)
2012-09-24 22:02 PDT
,
Laszlo Gombos
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Laszlo Gombos
Comment 1
2012-09-24 22:02:59 PDT
Created
attachment 165520
[details]
use the same versions in both places
WebKit Review Bot
Comment 2
2012-09-25 01:14:36 PDT
Comment on
attachment 165520
[details]
use the same versions in both places Clearing flags on attachment: 165520 Committed
r129472
: <
http://trac.webkit.org/changeset/129472
>
WebKit Review Bot
Comment 3
2012-09-25 01:14:40 PDT
All reviewed patches have been landed. Closing bug.
Raphael Kubo da Costa (:rakuco)
Comment 4
2012-09-25 04:44:44 PDT
We normally bump the required versions in OptionsEfl.cmake with less frequency than in jhbuild.modules because the purpose of those two files is different -- the former is used even by people who are not developing the port and thus might not need the latest version of everything (we do not require EFL API from the 1.2 releases IIRC, for example), while the latter is used basically so that we generate consistent test results across different installations.
Adam Klein
Comment 5
2012-09-25 12:14:54 PDT
Reopening to attach new patch.
Adam Klein
Comment 6
2012-09-25 12:15:33 PDT
Erp, sorry for the noise, webkit-patch mishandling.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug