Bug 97523 - [EFL] Update minimal required versions
Summary: [EFL] Update minimal required versions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Klein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-24 21:58 PDT by Laszlo Gombos
Modified: 2012-09-25 12:15 PDT (History)
5 users (show)

See Also:


Attachments
use the same versions in both places (2.17 KB, patch)
2012-09-24 22:02 PDT, Laszlo Gombos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2012-09-24 21:58:17 PDT
It seems that there are 2 place in the source tree where the minimal required version for the dependencies are stored; 1./ OptionsEfl.cmake and 2./ jhbuild.modules. 

I propose that we should try to keep the 2 aligned or alternatively we should only enforce the version check in one place but not in the other place.
Comment 1 Laszlo Gombos 2012-09-24 22:02:59 PDT
Created attachment 165520 [details]
use the same versions in both places
Comment 2 WebKit Review Bot 2012-09-25 01:14:36 PDT
Comment on attachment 165520 [details]
use the same versions in both places

Clearing flags on attachment: 165520

Committed r129472: <http://trac.webkit.org/changeset/129472>
Comment 3 WebKit Review Bot 2012-09-25 01:14:40 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Raphael Kubo da Costa (:rakuco) 2012-09-25 04:44:44 PDT
We normally bump the required versions in OptionsEfl.cmake with less frequency than in jhbuild.modules because the purpose of those two files is different -- the former is used even by people who are not developing the port and thus might not need the latest version of everything (we do not require EFL API from the 1.2 releases IIRC, for example), while the latter is used basically so that we generate consistent test results across different installations.
Comment 5 Adam Klein 2012-09-25 12:14:54 PDT
Reopening to attach new patch.
Comment 6 Adam Klein 2012-09-25 12:15:33 PDT
Erp, sorry for the noise, webkit-patch mishandling.