Bug 104260 – REGRESSION(r136788): Asserts on EFL WebKit2 Debug bot (Requested by yael on #webkit).

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[WebKit Review Bot]

http://trac.webkit.org/changeset/136788 broke the build:
Asserts on EFL WebKit2 Debug bot (Requested by yael on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Review Bot]

Created attachment 178007 [details]
ROLLOUT of r136788

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

[WebKit Review Bot]

Comment on attachment 178007 [details]
ROLLOUT of r136788

Clearing flags on attachment: 178007

Committed r136841: <http://trac.webkit.org/changeset/136841>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Dongseong Hwang]

Comment on attachment 178007 [details]
ROLLOUT of r136788

View in context: https://bugs.webkit.org/attachment.cgi?id=178007&action=review

> Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:-331
> -    ASSERT(m_rootLayerID != InvalidWebLayerID);

This bug rolled out wrong bug.
The bug that failed debug build is Bug 103983.
Bug 103983 renamed from InvalidWebLayerID to CoordinatedLayerID except for this line.
However, it's ok. I'll roll back this bug as well as Bug 104260.

[Dongseong Hwang]

(In reply to comment #4)
> (From update of attachment 178007 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=178007&action=review
> 
> > Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:-331
> > -    ASSERT(m_rootLayerID != InvalidWebLayerID);
> 
> This bug rolled out wrong bug.
> The bug that failed debug build is Bug 103983.
> Bug 103983 renamed from InvalidWebLayerID to CoordinatedLayerID except for this line.
> However, it's ok. I'll roll back this bug as well as Bug 104260.

I think I made a mistake after rethinking. rolling out was good to me. thank you. I'll investigate more.