Bug 103983 - Coordinated Graphics: Rename WebLayerTreeInfo to CoordinatedLayerInfo
Summary: Coordinated Graphics: Rename WebLayerTreeInfo to CoordinatedLayerInfo
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 102994
  Show dependency treegraph
 
Reported: 2012-12-04 01:26 PST by Jae Hyun Park
Modified: 2012-12-06 17:46 PST (History)
8 users (show)

See Also:


Attachments
Patch (57.94 KB, patch)
2012-12-04 01:31 PST, Jae Hyun Park
no flags Details | Formatted Diff | Diff
Patch (57.88 KB, patch)
2012-12-05 01:18 PST, Jae Hyun Park
jaepark: review+
jaepark: commit-queue-
Details | Formatted Diff | Diff
Patch (60.56 KB, patch)
2012-12-05 20:10 PST, Jae Hyun Park
no flags Details | Formatted Diff | Diff
Patch (60.56 KB, patch)
2012-12-06 16:53 PST, Jae Hyun Park
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jae Hyun Park 2012-12-04 01:26:13 PST
Currently, WebLayerTreeInfo only has WebLayerInfo as a struct. Also, it is hard to know what WebLayer is since we don't use that name anymore. More appropriate name for WebLayerInfo would be CoordinatedLayerInfo.
Comment 1 Jae Hyun Park 2012-12-04 01:31:02 PST
Created attachment 177444 [details]
Patch
Comment 2 Noam Rosenthal 2012-12-05 01:08:54 PST
Comment on attachment 177444 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=177444&action=review

> Source/WebKit2/Scripts/webkit2/messages.py:400
> +        'WebKit::CoordinatedLayerInfo': ['"CoordinatedLayerInfo.h"'],

This is not needed
Comment 3 Jae Hyun Park 2012-12-05 01:18:50 PST
Created attachment 177695 [details]
Patch
Comment 4 Jae Hyun Park 2012-12-05 01:19:18 PST
(In reply to comment #2)
> (From update of attachment 177444 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=177444&action=review
> 
> > Source/WebKit2/Scripts/webkit2/messages.py:400
> > +        'WebKit::CoordinatedLayerInfo': ['"CoordinatedLayerInfo.h"'],
> 
> This is not needed
Fixed.

Thanks for the review!
Comment 5 WebKit Review Bot 2012-12-05 16:59:25 PST
Comment on attachment 177695 [details]
Patch

Rejecting attachment 177695 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
to file Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp.rej
patching file Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h
Hunk #1 FAILED at 78.
1 out of 3 hunks FAILED -- saving rejects to file Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Noam Rosen..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/15174038
Comment 6 Jae Hyun Park 2012-12-05 20:10:17 PST
Created attachment 177914 [details]
Patch
Comment 7 Jae Hyun Park 2012-12-06 16:53:41 PST
Created attachment 178111 [details]
Patch
Comment 8 WebKit Review Bot 2012-12-06 17:46:04 PST
Comment on attachment 178111 [details]
Patch

Clearing flags on attachment: 178111

Committed r136912: <http://trac.webkit.org/changeset/136912>
Comment 9 WebKit Review Bot 2012-12-06 17:46:09 PST
All reviewed patches have been landed.  Closing bug.