WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
103983
Coordinated Graphics: Rename WebLayerTreeInfo to CoordinatedLayerInfo
https://bugs.webkit.org/show_bug.cgi?id=103983
Summary
Coordinated Graphics: Rename WebLayerTreeInfo to CoordinatedLayerInfo
Jae Hyun Park
Reported
2012-12-04 01:26:13 PST
Currently, WebLayerTreeInfo only has WebLayerInfo as a struct. Also, it is hard to know what WebLayer is since we don't use that name anymore. More appropriate name for WebLayerInfo would be CoordinatedLayerInfo.
Attachments
Patch
(57.94 KB, patch)
2012-12-04 01:31 PST
,
Jae Hyun Park
no flags
Details
Formatted Diff
Diff
Patch
(57.88 KB, patch)
2012-12-05 01:18 PST
,
Jae Hyun Park
jaepark
: review+
jaepark
: commit-queue-
Details
Formatted Diff
Diff
Patch
(60.56 KB, patch)
2012-12-05 20:10 PST
,
Jae Hyun Park
no flags
Details
Formatted Diff
Diff
Patch
(60.56 KB, patch)
2012-12-06 16:53 PST
,
Jae Hyun Park
no flags
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
Jae Hyun Park
Comment 1
2012-12-04 01:31:02 PST
Created
attachment 177444
[details]
Patch
Noam Rosenthal
Comment 2
2012-12-05 01:08:54 PST
Comment on
attachment 177444
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=177444&action=review
> Source/WebKit2/Scripts/webkit2/messages.py:400 > + 'WebKit::CoordinatedLayerInfo': ['"CoordinatedLayerInfo.h"'],
This is not needed
Jae Hyun Park
Comment 3
2012-12-05 01:18:50 PST
Created
attachment 177695
[details]
Patch
Jae Hyun Park
Comment 4
2012-12-05 01:19:18 PST
(In reply to
comment #2
)
> (From update of
attachment 177444
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=177444&action=review
> > > Source/WebKit2/Scripts/webkit2/messages.py:400 > > + 'WebKit::CoordinatedLayerInfo': ['"CoordinatedLayerInfo.h"'], > > This is not needed
Fixed. Thanks for the review!
WebKit Review Bot
Comment 5
2012-12-05 16:59:25 PST
Comment on
attachment 177695
[details]
Patch Rejecting
attachment 177695
[details]
from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: to file Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp.rej patching file Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h Hunk #1 FAILED at 78. 1 out of 3 hunks FAILED -- saving rejects to file Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Noam Rosen..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output:
http://queues.webkit.org/results/15174038
Jae Hyun Park
Comment 6
2012-12-05 20:10:17 PST
Created
attachment 177914
[details]
Patch
Jae Hyun Park
Comment 7
2012-12-06 16:53:41 PST
Created
attachment 178111
[details]
Patch
WebKit Review Bot
Comment 8
2012-12-06 17:46:04 PST
Comment on
attachment 178111
[details]
Patch Clearing flags on attachment: 178111 Committed
r136912
: <
http://trac.webkit.org/changeset/136912
>
WebKit Review Bot
Comment 9
2012-12-06 17:46:09 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug