RESOLVED FIXED 104151
[Chromium] Move WorkerContextProxy::create out of PlatformSupport 
https://bugs.webkit.org/show_bug.cgi?id=104151
Summary [Chromium] Move WorkerContextProxy::create out of PlatformSupport
Mark Pilgrim (Google)
Reported 2012-12-05 11:53:58 PST
[Chromium] Move WorkerContextProxy::create out of PlatformSupport
Attachments
Patch (4.68 KB, patch)
2012-12-05 11:54 PST, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Patch (4.67 KB, patch)
2012-12-07 05:49 PST, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Patch (4.65 KB, patch)
2012-12-07 05:51 PST, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Mark Pilgrim (Google)
Comment 1 2012-12-05 11:54:56 PST
Created attachment 177803 [details] Patch
WebKit Review Bot
Comment 2 2012-12-05 12:50:15 PST
Comment on attachment 177803 [details] Patch Clearing flags on attachment: 177803 Committed r136741: <http://trac.webkit.org/changeset/136741>
WebKit Review Bot
Comment 3 2012-12-05 12:50:19 PST
All reviewed patches have been landed. Closing bug.
Stephen White
Comment 4 2012-12-05 13:17:40 PST
Reverted r136741 for reason: Broke Chrome/Win build. Committed r136748: <http://trac.webkit.org/changeset/136748>
Adam Barth
Comment 5 2012-12-05 18:05:37 PST
Comment on attachment 177803 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177803&action=review > Source/WebKit/chromium/src/WorkerContextProxy.cpp:42 > +WebCore::WorkerContextProxy* WebCore::WorkerContextProxy::create(WebCore::Worker* worker) You shouldn't need all these "WebCore" prefixes. You're already in the WebCore namespace.
Adam Barth
Comment 6 2012-12-05 18:06:19 PST
You might need to put this function in another file to make the windows component build happy. It's really finicky about dropping files that it thinks are unused.
Mark Pilgrim (Google)
Comment 7 2012-12-06 08:38:23 PST
This was only rolled back because it went in at around the same time as bug 102699, which had to be rolled back due to breakage downstream. (Sigh.) There's nothing wrong with this patch in and of itself (but I'll fix the unnecessary prefixes).
Mark Pilgrim (Google)
Comment 8 2012-12-07 05:49:21 PST
Created attachment 178206 [details] Patch
Mark Pilgrim (Google)
Comment 9 2012-12-07 05:51:10 PST
Created attachment 178207 [details] Patch
Mark Pilgrim (Google)
Comment 10 2012-12-07 05:51:31 PST
Comment on attachment 178207 [details] Patch Actually removed prefixes this time.
Kentaro Hara
Comment 11 2012-12-07 06:03:31 PST
Comment on attachment 178207 [details] Patch ok
WebKit Review Bot
Comment 12 2012-12-07 06:48:40 PST
Comment on attachment 178207 [details] Patch Clearing flags on attachment: 178207 Committed r136951: <http://trac.webkit.org/changeset/136951>
WebKit Review Bot
Comment 13 2012-12-07 06:48:44 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.