Bug 102699 - [Chromium][Win] Remove theme-related functions from PlatformSupport
Summary: [Chromium][Win] Remove theme-related functions from PlatformSupport
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Pilgrim (Google)
URL:
Keywords:
Depends on:
Blocks: 82948
  Show dependency tree / graph
 
Reported: 2012-11-19 11:20 PST by Mark Pilgrim (Google)
Modified: 2012-12-10 13:34 PST (History)
8 users (show)

See Also:

Attachments
Patch (19.10 KB, patch)
2012-11-19 11:23 PST, Mark Pilgrim (Google) 		no flags Details | Formatted Diff | Diff
Re-patched to ToT (19.17 KB, patch)
2012-11-28 10:58 PST, Mark Pilgrim (Google) 		no flags Details | Formatted Diff | Diff
Repatched to ToT (19.21 KB, patch)
2012-12-04 13:05 PST, Mark Pilgrim (Google) 		no flags Details | Formatted Diff | Diff
Patch (17.35 KB, patch)
2012-12-10 11:10 PST, Mark Pilgrim (Google) 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Pilgrim (Google) 2012-11-19 11:20:16 PST 
[Chromium][Win] Remove theme-related functions from PlatformSupport
Comment 1 Mark Pilgrim (Google) 2012-11-19 11:23:35 PST 
Created attachment 175010 [details]
Patch
Comment 2 Mark Pilgrim (Google) 2012-11-28 10:58:18 PST 
Created attachment 176524 [details]
Re-patched to ToT
Comment 3 Adam Barth 2012-11-28 12:47:11 PST 
Comment on attachment 176524 [details]
Re-patched to ToT

View in context: https://bugs.webkit.org/attachment.cgi?id=176524&action=review

> Source/WebKit/chromium/src/PlatformSupport.cpp:-205
> -    RGBA32 backgroundColor = color.isValid() ? color.rgb() : Color::white;

I see.  This is redundant with the work done by the one caller.  Nice.
Comment 4 Mark Pilgrim (Google) 2012-12-04 13:05:02 PST 
Created attachment 177532 [details]
Repatched to ToT
Comment 5 WebKit Review Bot 2012-12-05 12:31:11 PST 
Comment on attachment 177532 [details]
Repatched to ToT

Clearing flags on attachment: 177532

Committed r136735: <http://trac.webkit.org/changeset/136735>
Comment 6 WebKit Review Bot 2012-12-05 12:31:15 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Stephen White 2012-12-05 13:18:52 PST 
Reverted r136735 for reason:

Broke Chrome/Win build.

Committed r136749: <http://trac.webkit.org/changeset/136749>
Comment 8 Mark Pilgrim (Google) 2012-12-10 11:10:25 PST 
Created attachment 178595 [details]
Patch
Comment 9 Mark Pilgrim (Google) 2012-12-10 11:10:52 PST 
Comment on attachment 178595 [details]
Patch

Fixed downstream issues, repatched to ToT.
Comment 10 Stephen White 2012-12-10 12:36:12 PST 
Has the appropriate Chrome revision been rolled into WebKit?  (Source/WebKit/chromium/DEPS)
Comment 11 Darin Fisher (:fishd, Google) 2012-12-10 12:43:21 PST 
(In reply to comment #10)
> Has the appropriate Chrome revision been rolled into WebKit?  (Source/WebKit/chromium/DEPS)

This isn't changing WebKit API, so there should be no such dependency.
Comment 12 WebKit Review Bot 2012-12-10 13:34:17 PST 
Comment on attachment 178595 [details]
Patch

Clearing flags on attachment: 178595

Committed r137201: <http://trac.webkit.org/changeset/137201>
Comment 13 WebKit Review Bot 2012-12-10 13:34:21 PST 
All reviewed patches have been landed.  Closing bug.