Bug 104106 - Implement add64 for MIPS assembler after r136601
Summary: Implement add64 for MIPS assembler after r136601
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 420+
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 102999
  Show dependency tree / graph
 
Reported: 2012-12-05 02:28 PST by Balazs Kilvady
Modified: 2012-12-18 07:22 PST (History)
10 users (show)

See Also:

Attachments
proposed patch (1.82 KB, patch)
2012-12-05 05:03 PST, Balazs Kilvady 		no flags Details | Formatted Diff | Diff
Fixed patch for signed add. (2.99 KB, patch)
2012-12-17 08:48 PST, Balazs Kilvady 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Balazs Kilvady 2012-12-05 02:28:25 PST 
+++ This bug was initially created as a clone of Bug #104103 +++

r136601 broke the MIPS build:

/data/kilvadyb/webkit-mips/webkit/Source/JavaScriptCore/jit/JIT.cpp: In member function 'void JSC::JIT::privateCompileMainPass()':
/data/kilvadyb/webkit-mips/webkit/Source/JavaScriptCore/jit/JIT.cpp:241: error: 'add64' was not declared in this scope

It seems MIPS assembler needs add64.
Comment 1 Balazs Kilvady 2012-12-05 05:03:04 PST 
Created attachment 177730 [details]
proposed patch
Comment 2 Peter Gal 2012-12-17 01:56:32 PST 
So... are we waiting for something?
Comment 3 Csaba Osztrogonác 2012-12-17 02:06:59 PST 
(In reply to comment #2)
> So... are we waiting for something?

Yes. For review.
Comment 4 Csaba Osztrogonác 2012-12-17 02:13:26 PST 
cc more JSC reviewers
Comment 5 Balazs Kilvady 2012-12-17 08:48:57 PST 
Created attachment 179753 [details]
Fixed patch for signed add.
Comment 6 Zoltan Herczeg 2012-12-17 10:03:34 PST 
Comment on attachment 179753 [details]
Fixed patch for signed add.

r=me. Tricky patch :)
Comment 7 WebKit Review Bot 2012-12-17 10:26:12 PST 
Comment on attachment 179753 [details]
Fixed patch for signed add.

Clearing flags on attachment: 179753

Committed r137919: <http://trac.webkit.org/changeset/137919>
Comment 8 WebKit Review Bot 2012-12-17 10:26:17 PST 
All reviewed patches have been landed.  Closing bug.