Bug 103918 - [CMake] Enable building WebKit sources without Tools
Summary: [CMake] Enable building WebKit sources without Tools
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-03 12:42 PST by Laszlo Gombos
Modified: 2012-12-05 11:00 PST (History)
6 users (show)

See Also:


Attachments
proposed patch (1.82 KB, patch)
2012-12-03 12:54 PST, Laszlo Gombos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2012-12-03 12:42:41 PST
This build configuration could be useful for:
 - downstream in a productization branch for package maintainers) where Tools directory might not be used/needed
 - building just WebKit sources without building Tools for faster build times
 - ENABLE_TOOLS cmake variable was always set to true, which made not much sense - we should allow it to be configurable
Comment 1 Laszlo Gombos 2012-12-03 12:54:34 PST
Created attachment 177313 [details]
proposed patch

Also moved a section of the code so that the TOOLS_DIR variable is initialized before it gets used.

As a test I create a directory with only CMakeLists.txt file and the Source directory in it and successfully built the EFL WebKit port from it by invoking cmake directly (instead of using the build-webkit script).
Comment 2 Gyuyoung Kim 2012-12-04 21:17:17 PST
Comment on attachment 177313 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=177313&action=review

Looks find on my side.

> CMakeLists.txt:-14
> -SET(ENABLE_WEBCORE ON)

Should we move existing place to here ?
Comment 3 Gyuyoung Kim 2012-12-04 21:25:08 PST
Comment on attachment 177313 [details]
proposed patch

typo : find -> fine.
Comment 4 Laszlo Gombos 2012-12-05 10:54:31 PST
(In reply to comment #2)
> (From update of attachment 177313 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=177313&action=review
> 
> Looks find on my side.
> 
> > CMakeLists.txt:-14
> > -SET(ENABLE_WEBCORE ON)
> 
> Should we move existing place to here ?

This should be done together with a bigger refactoring as a separate patch. I think this variable should not even be exposed at this level and should be moved under Source - see bug 104083.
Comment 5 WebKit Review Bot 2012-12-05 11:00:10 PST
Comment on attachment 177313 [details]
proposed patch

Clearing flags on attachment: 177313

Committed r136715: <http://trac.webkit.org/changeset/136715>
Comment 6 WebKit Review Bot 2012-12-05 11:00:15 PST
All reviewed patches have been landed.  Closing bug.