WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
104083
[CMake] Proper encapsulation of WebKit CMake rules
https://bugs.webkit.org/show_bug.cgi?id=104083
Summary
[CMake] Proper encapsulation of WebKit CMake rules
Laszlo Gombos
Reported
2012-12-04 21:08:42 PST
It seems to me that many of the rules in the top /CMakeLists.txt should be moved to /Source/CMakeLists.txt as most of the rules in /CMakeLists.txt are only relevant for files under /Source (and not for example relevant for /Tools). As an example /Makefile is a good example how to the the encapsulation properly. The top level /CMakeLists.txt should be really only responsible for invoking sub projects under /Source and /Tools and it should not specify details how things under /Source are built.
Attachments
Add attachment
proposed patch, testcase, etc.
Fujii Hironori
Comment 1
2024-08-05 18:56:18 PDT
This has been done already.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug