Bug 103875 - [Qt][WK2] New resize tests fail
Summary: [Qt][WK2] New resize tests fail
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 420+
Hardware: All All
: P2 Normal
Assignee: Michael Brüning
URL:
Keywords:
Depends on:
Blocks: 70236 103521
  Show dependency treegraph
 
Reported: 2012-12-03 03:45 PST by Csaba Osztrogonác
Modified: 2012-12-03 06:28 PST (History)
7 users (show)

See Also:


Attachments
Patch (1.42 KB, patch)
2012-12-03 05:33 PST, Michael Brüning
jturcotte: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2012-12-03 03:45:04 PST
New tests introduced in http://trac.webkit.org/changeset/136129, but all of them fail:

PASS   : qmltests::Resize::initTestCase()
FAIL!  : qmltests::Resize::test_basic() Uncaught exception: viewportSpy is not defined
   Loc: [(0)]
FAIL!  : qmltests::Resize::test_resizeAfterNeutralZoom() Uncaught exception: viewportSpy is not defined
   Loc: [(0)]
FAIL!  : qmltests::Resize::test_resizeZoomedIn() Uncaught exception: viewportSpy is not defined
   Loc: [(0)]
FAIL!  : qmltests::Resize::test_resizeZoomedIn() 'wait for signal contentsScaleCommitted' returned FALSE. ()
   Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_resize.qml(79)]
PASS   : qmltests::Resize::cleanupTestCase()
Comment 1 Michael Brüning 2012-12-03 03:59:12 PST
Seems as if the viewport spy has not been declared. Fixing.
Comment 2 Michael Brüning 2012-12-03 05:33:14 PST
Created attachment 177237 [details]
Patch
Comment 3 Michael Brüning 2012-12-03 06:28:06 PST
Committed r136391: <http://trac.webkit.org/changeset/136391>