Bug 103768 – REGRESSION(r136142): break a bunch of interactive_ui_tests in chromium win (Requested by zhenyao_home on #webkit).

• Status: RESOLVED
• Resolution: WONTFIX
• Component: New Bugs

[WebKit Review Bot]

http://trac.webkit.org/changeset/136142 broke the build:
break a bunch of interactive_ui_tests in chromium win (Requested by zhenyao_home on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Review Bot]

Created attachment 177017 [details]
ROLLOUT of r136142

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

[Zhenyao Mo]

Roll webkit to 136141, the tests run OK: https://codereview.chromium.org/11316282/

Roll webkit to 136142, the tests start to fail:
https://codereview.chromium.org/11299280/

136143 is definitely innocent: http://trac.webkit.org/changeset/136143

So it's clear this patch causes the failure.

We have 140+ patches piling up waiting to be rolled into chromium.  So I am rolling this out for now.  More than happy to help investigate, but definitely not while I am gardener.

[Zhenyao Mo]

Some more results:

roll to 136140, always pass: https://codereview.chromium.org/11348329/ and https://codereview.chromium.org/11428108/

roll to 136144, fail: https://codereview.chromium.org/11416290/

roll to 136145, fail: https://codereview.chromium.org/11428109/

It seems clear to me 136142 caused the failures

[WebKit Review Bot]

Comment on attachment 177017 [details]
ROLLOUT of r136142

Clearing flags on attachment: 177017

Committed r136275: <http://trac.webkit.org/changeset/136275>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Zhenyao Mo]

After more investigation, the failures seem to be fixed between range r136200 & r136220.  If I can confirm this, will land this patch again, but definitely after I rolled 140+ webkit into chromium.

[Ryosuke Niwa]

Can this patch be rolled back in?

[Zhenyao Mo]

I am still not very comfortable with this patch, but I'll try to roll it back in on Monday.

[Alexey Proskuryakov]

Ping?

[Ryosuke Niwa]

First off, I don't think you should be rolling out patches just because tests in some project that uses WebKit (Chromium) failed without giving out enough details as to why this is a serious regression that requires an immediate roll out.

Second, being busy rolling DEPS is not a good excuse to roll out a patch.

Third, please re-land patches as fast as you would roll out patches once they are found not innocent of causing test failures.

[Ryosuke Niwa]

I'm relanding the patch.

[Zhenyao Mo]

Sorry about that.  I planned to roll it in, and has been sick for the past a few days ...

Still sick, so if you can help with relanding, I'd appreciate that