Bug 103569 – Support ruby-position: {before, after}

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

Support ruby-position: {before, after}

<rdar://problem/12771885>

Created attachment 176593 [details]
Add -webkit-ruby-position: {before,after}

[WebKit Review Bot]

Comment on attachment 176593 [details]
Add -webkit-ruby-position: {before,after}

Attachment 176593 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15016602

New failing tests:
fast/ruby/position-after.html

(In reply to comment #3)
> (From update of attachment 176593 [details])
> Attachment 176593 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/15016602
> 
> New failing tests:
> fast/ruby/position-after.html

Moved the expected results to platform/mac, since I couldn’t see what the failure looked like.

Committed <http://trac.webkit.org/r136142>.

[Zhenyao Mo]

mitz: ping.  fast/ruby/position-after.html is failing in chromium.  Do you know why is that?  This is blocking me from rolling webkit into chromium.  Please get back to me soon.  Otherwise I'll have no choice but revert this patch.

Can you attach the pixel result from chromium so that I can see what is failing? Unfortunately the EWS bot didn't provide it.

[Zhenyao Mo]

I see what's wrong.  In the reviewed patch, the expectation files are under fast/ruby, which is for all platform, but in the landed patch, the expectation files are under platform/mac/fast/ruby

[Zhenyao Mo]

I'll rebaseline then.  I only looked at the reviewed patch in the beginning, that's why I was very confused.

(In reply to comment #7)
> I see what's wrong.  In the reviewed patch, the expectation files are under fast/ruby, which is for all platform, but in the landed patch, the expectation files are under platform/mac/fast/ruby

I explained why I did that in comment #4.

[Zhenyao Mo]

Created attachment 176804 [details]
results from chromium

[Zhenyao Mo]

I just attached one rendered image from chromium, please have a look and let me know if it's OK to move the expectations into fast/ruby.

(In reply to comment #11)
> I just attached one rendered image from chromium, please have a look and let me know if it's OK to move the expectations into fast/ruby.

These results show a genuine failure in the positioning of emphasis marks in vertical text in Chromium. I doubt that the failure is new as a result of the patch. You should probably file a bug about that and skip the test on Chromium. You could also move the results to fast/ruby.

[Jussi Kukkonen (jku)]

(In reply to comment #12)
> (In reply to comment #11)
> > I just attached one rendered image from chromium, please have a look and let me know if it's OK to move the expectations into fast/ruby.
> 
> These results show a genuine failure in the positioning of emphasis marks in vertical text in Chromium. I doubt that the failure is new as a result of the patch. You should probably file a bug about that and skip the test on Chromium. You could also move the results to fast/ruby.

That would probably be best. Currently this test fails on all bots except mac.

Thats said, I was just about to move the mac results to non-platform specific folder as the positioning on EFL is the same, when I realised the images have a strange color problem: In the efl results the 0000FF elements are really 0000FF but in the mac png results they seem to be 0433FF. Is this supposed to happen?

[Kent Tamura]

Please announce the feature to webkit-dev though I think no one objects it.
http://www.webkit.org/coding/adding-features.html

(In reply to comment #14)
> Please announce the feature to webkit-dev though I think no one objects it.
> http://www.webkit.org/coding/adding-features.html

Done. Thanks for the reminder!

[WebKit Review Bot]

Re-opened since this is blocked by bug 103768

[Ryosuke Niwa]

Committed r137359: <http://trac.webkit.org/changeset/137359>