RESOLVED FIXED 103648
[chromium] Tell WebInputHandlerClient when end of input is reached for current vsync period
https://bugs.webkit.org/show_bug.cgi?id=103648
Summary [chromium] Tell WebInputHandlerClient when end of input is reached for curren...
Sami Kyöstilä
Reported 2012-11-29 09:42:10 PST
[chromium] Tell WebInputHandlerClient when end of input is reached for current vsync period
Attachments
Patch (4.58 KB, patch)
2012-11-29 12:06 PST, Sami Kyöstilä
no flags
Patch (4.72 KB, patch)
2012-12-03 09:09 PST, Sami Kyöstilä
no flags
Patch (4.71 KB, patch)
2012-12-03 09:35 PST, Sami Kyöstilä
no flags
Sami Kyöstilä
Comment 1 2012-11-29 12:06:02 PST
WebKit Review Bot
Comment 2 2012-11-29 12:09:09 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Peter Beverloo (cr-android ews)
Comment 3 2012-11-29 13:17:12 PST
Comment on attachment 176778 [details] Patch Attachment 176778 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/15056037
Darin Fisher (:fishd, Google)
Comment 4 2012-11-29 14:30:24 PST
Comment on attachment 176778 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176778&action=review > Source/Platform/chromium/public/WebInputHandlerClient.h:78 > + virtual void onEndOfInput() { } nit: WebKit APIs do not normally use the "on" prefix for events. Prefer "did" or "will" as suffixes to make it more clear if the event is occurring before or after some state change.
WebKit Review Bot
Comment 5 2012-11-29 15:18:51 PST
Comment on attachment 176778 [details] Patch Attachment 176778 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15054138
Sami Kyöstilä
Comment 6 2012-12-03 09:03:29 PST
(In reply to comment #4) > nit: WebKit APIs do not normally use the "on" prefix for events. Prefer "did" or "will" as suffixes to make it more clear if the event is occurring before or after some state change. Great point, done.
Sami Kyöstilä
Comment 7 2012-12-03 09:09:58 PST
Peter Beverloo
Comment 8 2012-12-03 09:27:12 PST
Comment on attachment 177268 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177268&action=review Some minor drive-by nits.. > Source/Platform/chromium/public/WebInputHandlerClient.h:76 > + // Indicate that the final input evet for the current vsync interval was nit: s/evet/event/. Since there is no 80-character line length limit in WebKit, it should be fine to put "received." on this line.
Sami Kyöstilä
Comment 9 2012-12-03 09:34:57 PST
(In reply to comment #8) > nit: s/evet/event/. Since there is no 80-character line length limit in WebKit, it should be fine to put "received." on this line. Thanks, fixed.
Sami Kyöstilä
Comment 10 2012-12-03 09:35:30 PST
WebKit Review Bot
Comment 11 2012-12-03 11:16:29 PST
Comment on attachment 177274 [details] Patch Clearing flags on attachment: 177274 Committed r136421: <http://trac.webkit.org/changeset/136421>
WebKit Review Bot
Comment 12 2012-12-03 11:16:33 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.