Bug 103647 – [chromium] Mark last input event for current vsync interval

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sami Kyöstilä]

[chromium] Mark last input event for current vsync interval

[Sami Kyöstilä]

Created attachment 176749 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[James Robinson]

Comment on attachment 176749 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176749&action=review

> Source/WebKit/chromium/public/WebInputEvent.h:169
> +    bool endOfInput; // Last input event for the current vsync interval.

I think this name needs to be a bit more descriptive.  The comment is good

> Source/WebKit/chromium/src/WebInputEvent.cpp:47
> +    int inputData[6];

that's sad - can we fit this in somewhere else? modifiers seems to have plenty of bits available

[Sami Kyöstilä]

Created attachment 176961 [details]
Patch

How's this?

[James Robinson]

Comment on attachment 176961 [details]
Patch

I think it's pretty good!  Darin/Adam - does this make enough sense for folks who aren't living in compositor land all day, or do you think we should segregate this out some more?

[Adam Barth]

Comment on attachment 176961 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176961&action=review

> Source/WebKit/chromium/public/WebInputEvent.h:162
> +        // Last input event to be sent for the current vsync interval.
> +        IsLastInputEventForCurrentVSync = 1 << 13,

Seems fine to me.  Will this bit be set accurately on every OS?  If not, it might be worth explaining in the comment that this is OS(ANDROID) specific.

[James Robinson]

I think it'll be false by default, which is a fine value to set since that means the sender of the input events can't promise that this is the last input of a vsync.  It's only set when the embedder has knowledge.

[James Robinson]

Comment on attachment 176961 [details]
Patch

R=me but documenting what it means for the flag to be false would help.

[Sami Kyöstilä]

Created attachment 177224 [details]
Patch

Patch for landing.

[WebKit Review Bot]

Comment on attachment 177224 [details]
Patch

Clearing flags on attachment: 177224

Committed r136383: <http://trac.webkit.org/changeset/136383>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.