Bug 103511 - [EFL] Generate big_button_theme.edj
Summary: [EFL] Generate big_button_theme.edj
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-28 05:36 PST by Ryuan Choi
Modified: 2012-11-28 23:11 PST (History)
7 users (show)

See Also:

Attachments
Patch (147.95 KB, patch)
2012-11-28 21:12 PST, Ryuan Choi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2012-11-28 05:36:38 PST 
big_button_theme.edj is used to test but it should be compiled as bug 102037 #23 comments.
Comment 1 Dominik Röttsches (drott) 2012-11-28 05:39:24 PST 
What is big_button_theme used for? I hope it's not override control sizes, cmp. bug 85877.
Comment 2 Chris Dumez 2012-11-28 06:00:42 PST 
(In reply to comment #1)
> What is big_button_theme used for? I hope it's not override control sizes, cmp. bug 85877.

Only used by API tests.
Comment 3 Ryuan Choi 2012-11-28 06:11:29 PST 
(In reply to comment #2)
> (In reply to comment #1)
> > What is big_button_theme used for? I hope it's not override control sizes, cmp. bug 85877.
> 
> Only used by API tests.

Yes, it is just used for ewk_view_theme_set tests and it already exists.
Comment 4 Dominik Röttsches (drott) 2012-11-28 06:21:55 PST 
Chris, Ryuan - thanks for the clarification.
Comment 5 Ryuan Choi 2012-11-28 21:12:20 PST 
Created attachment 176638 [details]
Patch
Comment 6 Chris Dumez 2012-11-28 21:58:44 PST 
Comment on attachment 176638 [details]
Patch

Looks OK for me but someone should take a closer look at the CMake changes.
Comment 7 Gyuyoung Kim 2012-11-28 22:42:14 PST 
Comment on attachment 176638 [details]
Patch

Looks fine.
Comment 8 WebKit Review Bot 2012-11-28 23:11:04 PST 
Comment on attachment 176638 [details]
Patch

Clearing flags on attachment: 176638

Committed r136103: <http://trac.webkit.org/changeset/136103>
Comment 9 WebKit Review Bot 2012-11-28 23:11:08 PST 
All reviewed patches have been landed.  Closing bug.