RESOLVED FIXED 103511
[EFL] Generate big_button_theme.edj 
https://bugs.webkit.org/show_bug.cgi?id=103511
Summary [EFL] Generate big_button_theme.edj
Ryuan Choi
Reported 2012-11-28 05:36:38 PST
big_button_theme.edj is used to test but it should be compiled as bug 102037 #23 comments.
Attachments
Patch (147.95 KB, patch)
2012-11-28 21:12 PST, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dominik Röttsches (drott)
Comment 1 2012-11-28 05:39:24 PST
What is big_button_theme used for? I hope it's not override control sizes, cmp. bug 85877.
Chris Dumez
Comment 2 2012-11-28 06:00:42 PST
(In reply to comment #1) > What is big_button_theme used for? I hope it's not override control sizes, cmp. bug 85877. Only used by API tests.
Ryuan Choi
Comment 3 2012-11-28 06:11:29 PST
(In reply to comment #2) > (In reply to comment #1) > > What is big_button_theme used for? I hope it's not override control sizes, cmp. bug 85877. > > Only used by API tests. Yes, it is just used for ewk_view_theme_set tests and it already exists.
Dominik Röttsches (drott)
Comment 4 2012-11-28 06:21:55 PST
Chris, Ryuan - thanks for the clarification.
Ryuan Choi
Comment 5 2012-11-28 21:12:20 PST
Created attachment 176638 [details] Patch
Chris Dumez
Comment 6 2012-11-28 21:58:44 PST
Comment on attachment 176638 [details] Patch Looks OK for me but someone should take a closer look at the CMake changes.
Gyuyoung Kim
Comment 7 2012-11-28 22:42:14 PST
Comment on attachment 176638 [details] Patch Looks fine.
WebKit Review Bot
Comment 8 2012-11-28 23:11:04 PST
Comment on attachment 176638 [details] Patch Clearing flags on attachment: 176638 Committed r136103: <http://trac.webkit.org/changeset/136103>
WebKit Review Bot
Comment 9 2012-11-28 23:11:08 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.